From: Clemens Buchacher <drizzd@aon.at>
To: Finn Arne Gangstad <finnag@pvv.org>
Cc: git@vger.kernel.org, msysgit@googlegroups.com,
Eyvind Bernhardsen <eyvind.bernhardsen@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Dmitry Potapov <dpotapov@gmail.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH v2] autocrlf: Make it work also for un-normalized repositories
Date: Sun, 23 May 2010 11:30:40 +0200 [thread overview]
Message-ID: <20100523093040.GA15602@localhost> (raw)
In-Reply-To: <20100511223757.GB16974@pvv.org>
On Wed, May 12, 2010 at 12:37:57AM +0200, Finn Arne Gangstad wrote:
> Change autocrlf to not do any conversions to files that in the
> repository already contain a CR. git with autocrlf set will never
> create such a file, or change a LF only file to contain CRs, so the
> (new) assumption is that if a file contains a CR, it is intentional,
> and autocrlf should not change that.
I think this is a good change. But it only covers the part where we
translate CR -> LF when staging changes. With Eyvind's patches, if
I understand correctly, it will be possible to convert files to
have LF line endings. Such files will be translated from LF -> CR
when adding changes.
So if the file already has LF line endings, will this cause the
same problem the other way around?
Clemens
prev parent reply other threads:[~2010-05-23 9:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 22:37 [PATCH v2] autocrlf: Make it work also for un-normalized repositories Finn Arne Gangstad
2010-05-12 6:16 ` Dmitry Potapov
2010-05-12 6:33 ` Eyvind Bernhardsen
2010-05-12 9:26 ` Hnerik Grubbström
2010-05-23 9:30 ` Clemens Buchacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100523093040.GA15602@localhost \
--to=drizzd@aon.at \
--cc=Johannes.Schindelin@gmx.de \
--cc=dpotapov@gmail.com \
--cc=eyvind.bernhardsen@gmail.com \
--cc=finnag@pvv.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.