From: Jakub Narebski <jnareb@gmail.com>
To: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>,
Petr Baudis <pasky@suse.cz>
Cc: git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>,
Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCHv3 GSoC] git-instaweb: Configure it to work with new gitweb structure
Date: Sun, 23 May 2010 11:54:59 +0200 [thread overview]
Message-ID: <201005231155.00819.jnareb@gmail.com> (raw)
In-Reply-To: <1274599968-3749-1-git-send-email-pavan.sss1991@gmail.com>
On Sun, 23 May 2010, Pavan Kumar Sunkara wrote:
> git-instaweb in its current form (re)creates gitweb.cgi and
> (some of) required static files in $GIT_DIR/gitweb/ directory.
> Splitting gitweb would make it difficult for git-instaweb to
> continue with this method.
>
> Use the instaweb.gitwebdir config variable to point git-instaweb script
> to a global directory which contains gitweb files as server root
> and the httpd.conf along with server logs and pid go into
> '$(GIT_DIR)/gitweb' directory.
>
> While at it, change apache2 configuration to use the same access log
> and error log files as the rest of web servers supported by
> git-instaweb.
>
> Signed-off-by: Pavan Kumar Sunkara <pavan.sss1991@gmail.com>
For what it is worth:
Acked-by: Jakub Narebski <jnareb@gmail.com>
But I think more important would be ACK from Eric Wong, author and
maintainer of git-instaweb. I guess that because it is preparatory
work, only related to the main stated goal of your GSoC 2010, you
don't need "signoff" from mentor(s) (in the form of Mentored-by:)...
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-05-23 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-23 7:32 [PATCHv3 GSoC] git-instaweb: Configure it to work with new gitweb structure Pavan Kumar Sunkara
2010-05-23 9:54 ` Jakub Narebski [this message]
2010-05-23 9:56 ` Eric Wong
2010-05-23 10:18 ` Pavan Kumar Sunkara
2010-05-24 9:55 ` Christian Couder
2010-05-24 15:14 ` Pavan Kumar Sunkara
2010-05-25 1:34 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005231155.00819.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=pasky@suse.cz \
--cc=pavan.sss1991@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.