From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39360 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OGZE6-0000z9-Me
	for qemu-devel@nongnu.org; Mon, 24 May 2010 11:05:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <edgar.iglesias@axis.com>) id 1OGZE1-0006uL-UA
	for qemu-devel@nongnu.org; Mon, 24 May 2010 11:05:58 -0400
Received: from miranda.se.axis.com ([193.13.178.8]:50735)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <edgar.iglesias@axis.com>) id 1OGZE1-0006tp-H6
	for qemu-devel@nongnu.org; Mon, 24 May 2010 11:05:53 -0400
Date: Mon, 24 May 2010 16:57:52 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] linux-user mmap bug
Message-ID: <20100524145752.GA15283@edde.se.axis.com>
References: <20100521132817.GA8021@edde.se.axis.com>
	<4BF6B6F9.3070802@twiddle.net> <4BF6C548.2070400@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4BF6C548.2070400@twiddle.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Fri, May 21, 2010 at 10:39:20AM -0700, Richard Henderson wrote:
> On 05/21/2010 09:38 AM, Richard Henderson wrote:
> > I have a patch series that attempts to clean this up, but it 
> > isn't quite optimal.  I'll post it for reference, however.
> 
> Bah, the patch sequence no longer applies since Paul removed PAGE_RESERVED.

I took a look at the code again and I dont really understand how the
particular case when we get a high address from the kernel while
mmap_min_addr is busy case is supposed to work :/
In fact, for CRIS it never works on my host.

I get a high address that doesnt fit, then the code tries to go back
to mmap_min_addr but if that was busy my kernel just returns the
same addr we got the first try and mmap_find_vma gives -1 due to
repeat.

I changed it locally to keep scanning after a wrap until we succeed to
allocate a chunk or rewrap (SLOW) but at least I can run dynamically
linked CRIS programs again.

Cheers