All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: lsf10-pc@lists.linuxfoundation.org,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [Lsf10-pc] [LFS/VM TOPIC] Barriers and SYNCHRONZIE_CACHE
Date: Tue, 25 May 2010 13:41:21 +0200	[thread overview]
Message-ID: <20100525114120.GM23411@kernel.dk> (raw)
In-Reply-To: <4BFBADE9.4060904@suse.de>

On Tue, May 25 2010, Hannes Reinecke wrote:
> Hi all,
> 
> [Topic]
> Barriers and SYNCHRONIZE CACHE
> 
> [Abstract]
> In recent years some design flaws in the barriers implementation
> became apparent:
> - No indication about _which_ blocks to flush, so all outstanding
>   blocks are flushed
> - No error handling for SYNCHRONIZE CACHE
> - SYNCHRONIZE CACHE affects all I/Os, so if a LUN is used by
>   several virtual guests _all_ guests are affected
> - SYNCHRONIZE CACHE has a rather severe performance impact
>   on RAID controllers (if executed directly)
> 
> To overcome these issues I would propose to modify the
> barrier interface so that individual blocks can be
> marked as 'flushing'/'immediate'. This would allow
> the lower layers (eg. SCSI midlayer) to restrict
> the barriers operation on the affected blocks only.
> EG the SYNCHRONIZE_CACHE operation could be updated
> with a block list. Or more advanced methods (like FUA
> or tagging) could be used, avoiding the need to issue
> a SYNCHRONIZE CACHE altogether.

I think this is better handled over email for several reasons. Here's a
few of them:

- We've talked about barriers at each io/fs summit since we started
  holding those, and nothing has ever come out of it. Lets not waste
  more time _talking_ about it.

- Following from the previous entry, this is now at a point (and has
  been for probably 5 years) where the best way forward is discussion
  based on actual code.

- Yet another hand wavy discussion on how to improve barriers turns hair
  greyer. And at least personally, I don't need more grey hairs.

-- 
Jens Axboe


      reply	other threads:[~2010-05-25 11:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-25 11:00 [LFS/VM TOPIC] Barriers and SYNCHRONZIE_CACHE Hannes Reinecke
2010-05-25 11:41 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100525114120.GM23411@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lsf10-pc@lists.linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.