Re: [PATCH] udev: Use udev.inc and add udevadm to udev pacakge instead of udev-utils

[Khem Raj <raj.khem@gmail.com>]

On (25/05/10 09:22), Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 25-05-10 08:49, raj.khem@gmail.com wrote:
> > From: Khem Raj <raj.khem@gmail.com>
> > 
> > * Main purpose of the patch was to fix the problem where udev-utils was
> >   needed to be in root file system just to get udevadm binary. So this
> >   binary is moved into udev package instead.
> > 
> > * Use INC_PR
> > 
> > * Use udev.inc in all recipes.
> > 
> > * All udev recipes built udev_151 and udev_124 runs fine too.
> 
> I explicitly didn't use udev.inc in udev 151 because it made the recipe
> very hard to read. It would make more sense to do a udev-1xx.inc based
> on udev 151 and use that for future recipes.

On the contrary I thought it was more confusing to include udev.inc in some
and not in others.I find that the recipes are quite similar. infact do_install function could
be also commonized properly and extra bits put into install_append in given
recipes. I did not spend time doing that yet. 
Then the description field is also weirdly overridden in recipes probably
that needs fixing as well.

Any specific reason to have udev-1xx.inc ?

I will leave udev_151 as it is and only commit the udevadm change for now

-Khem