From: Christoph Hellwig <hch@infradead.org>
To: Will Drewry <wad@chromium.org>
Cc: linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Nick Piggin <npiggin@suse.de>, Tejun Heo <tj@kernel.org>,
Scott James Remnant <scott@ubuntu.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Harald Hoyer <harald@redhat.com>,
Christoph Lameter <cl@linux-foundation.org>,
agk@redhat.com, snitzer@redhat.com
Subject: Re: [PATCH 2/2] init, mount: export the name_to_dev_t symbol
Date: Tue, 25 May 2010 11:55:35 -0400 [thread overview]
Message-ID: <20100525155535.GA811@infradead.org> (raw)
In-Reply-To: <1274802411-26613-2-git-send-email-wad@chromium.org>
On Tue, May 25, 2010 at 10:46:51AM -0500, Will Drewry wrote:
> This change only adds EXPORT_SYMBOL() for name_to_dev_t.
>
> name_to_dev_t is in use outside of init/ but is not 'officially'
> exported. It provides behavior that is useful for any code that may be
> need to lookup a block device by major:minor or registered kernel name,
> especially before there is a root filesystem.
>
> Hopefully, this is the appropriate use of EXPORT_SYMBOL(). This
> specific function seems to be a stable interface and is available
> in include/linux/mount.h.
NACK. It's really a hack for the boot code, there's no offical name to
dev_t mapping.
What are you trying to use it for?
next prev parent reply other threads:[~2010-05-25 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 15:46 [PATCH 1/2] init: make the path argument a const in name_to_dev_t Will Drewry
2010-05-25 15:46 ` [PATCH 2/2] init, mount: export the name_to_dev_t symbol Will Drewry
2010-05-25 15:55 ` Christoph Hellwig [this message]
2010-05-25 16:05 ` Alasdair G Kergon
2010-05-25 16:11 ` Will Drewry
2010-05-25 17:21 ` Christoph Hellwig
2010-05-25 18:30 ` Mike Snitzer
2010-06-08 16:02 ` Will Drewry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525155535.GA811@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=cl@linux-foundation.org \
--cc=harald@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=scott@ubuntu.com \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
--cc=vegard.nossum@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.