From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paul Menage <menage@google.com>
Cc: Sridhar Samudrala <samudrala.sridhar@gmail.com>,
netdev <netdev@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
containers@lists.linux-foundation.org, lizf@cn.fujitsu.com
Subject: Re: [PATCH 1/3] cgroups: Add an API to attach a task to current task's cgroup
Date: Tue, 25 May 2010 19:53:34 +0300 [thread overview]
Message-ID: <20100525165334.GA27307@redhat.com> (raw)
In-Reply-To: <AANLkTinsrFoLVKDFM5pcKcL_6MvAzhR6IzbNmWKh3BDh@mail.gmail.com>
On Thu, May 20, 2010 at 03:22:15PM -0700, Paul Menage wrote:
> On Tue, May 18, 2010 at 5:04 PM, Sridhar Samudrala
> <samudrala.sridhar@gmail.com> wrote:
> > Add a new kernel API to attach a task to current task's cgroup
> > in all the active hierarchies.
> >
> > Signed-off-by: Sridhar Samudrala <sri@us.ibm.com>
>
> Reviewed-by: Paul Menage <menage@google.com>
>
> It would be more efficient to just attach directly to current->cgroups
> rather than potentially creating/destroying one css_set for each
> hierarchy until we've completely converged on current->cgroups - but
> that would require a bunch of refactoring of the guts of
> cgroup_attach_task() to ensure that the right can_attach()/attach()
> callbacks are made. That doesn't really seem worthwhile right now for
> the initial use, that I imagine isn't going to be
> performance-sensitive.
>
> Paul
Is this patch suitable for 2.6.35?
It is needed to fix the case where vhost user might cause a kernel thread
to consume more CPU than allowed by the cgroup.
Should I just merge it through the vhost tree?
Ack for this?
Thanks,
--
MST
next prev parent reply other threads:[~2010-05-25 16:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 0:04 [PATCH 1/3] cgroups: Add an API to attach a task to current task's cgroup Sridhar Samudrala
2010-05-20 22:22 ` Paul Menage
2010-05-20 22:22 ` Paul Menage
2010-05-20 22:26 ` Paul Menage
2010-05-20 22:26 ` Paul Menage
2010-05-21 15:09 ` Sridhar Samudrala
[not found] ` <AANLkTinsrFoLVKDFM5pcKcL_6MvAzhR6IzbNmWKh3BDh-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-25 16:53 ` Michael S. Tsirkin
2010-05-25 16:53 ` Michael S. Tsirkin [this message]
2010-05-25 18:34 ` Paul Menage
2010-05-25 18:34 ` Paul Menage
[not found] ` <AANLkTilawCLv5_XlStsFdOdLh-dmlIR3aUTyrVS-JF_s-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-05-27 9:16 ` Michael S. Tsirkin
2010-05-27 9:16 ` Michael S. Tsirkin
[not found] ` <20100525165334.GA27307-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2010-05-25 18:34 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525165334.GA27307@redhat.com \
--to=mst@redhat.com \
--cc=containers@lists.linux-foundation.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=netdev@vger.kernel.org \
--cc=samudrala.sridhar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.