From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [tabled patch 2/4] fix the selection of chunk
Date: Tue, 25 May 2010 21:25:13 -0600
Message-ID: <20100525212513.6bf932aa@redhat.com>
References: <20100521201945.28d2cce8@redhat.com>
	<4BFC52BB.7060509@garzik.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
In-Reply-To: <4BFC52BB.7060509@garzik.org>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
To: Jeff Garzik <jeff@garzik.org>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On Tue, 25 May 2010 18:44:11 -0400
Jeff Garzik <jeff@garzik.org> wrote:

> On 05/21/2010 10:19 PM, Pete Zaitcev wrote:

> > +static int object_node_select(int *nx, struct db_obj_ent *obj)
> > +{
> > +	struct storage_node *stnode;
> > +				if (stnode->up)
> > +					return stnode;

> Did you compile or test this???

I suppose I deserved the tripple question mark for this. I tested it,
of course. The funny thing, everything is mapped below 4GB, way below
actually. As for warnings, I managed to miss them, because I started
running with -Wpointer-arith -Wsign-compare recently and that floods.
There's a lesson in it somewhere.

-- Pete