From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Date: Wed, 26 May 2010 00:45:35 +0000 Subject: Re: [patch] mv_cesa: fixup error handling in mv_probe() Message-Id: <20100526004535.GF20073@gondor.apana.org.au> List-Id: References: <20100525094947.GF22515@bicker> In-Reply-To: <20100525094947.GF22515@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset="hz-gb-2312" Content-Transfer-Encoding: base64 To: Dan Carpenter Cc: "David S. Miller" , Uri Simchoni , Nicolas Pitre , Tejun Heo , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org T24gVHVlLCBNYXkgMjUsIDIwMTAgYXQgMTE6NDk6NDdBTSArMDIwMCwgRGFuIENhcnBlbnRlciB3 cm90ZToKPiBUaGUgZXJyb3IgaGFuZGxpbmcgaW4gbXZfcHJvYmUoKSB3YXMgYSBiaXQgbWVzc2Vk IHVwLiAgVGhlcmUgd2VyZSBzb21lIAo+IGdvdG9zIHRvIHRoZSB3cm9uZyBsYWJlbHMgc28gaXQg ZW5kZWQgdXAgcmVsZWFzaW5nIHN0dWZmIHRoYXQgdGhhdCBoYWRuJ3QKPiBiZWVuIGFxdWlyZWQg YW5kIG5vdCByZWxlYXNpbmcgc3R1ZmYgdGhhdCB3YXMgbWVhbnQgdG8gYmUgcmVsZWFzZWQuICBJ Cj4gc2h1ZmZsZWQgaXQgYXJvdW5kIGEgYml0IHRvIGZpeCBpdCBhbmQgbWFrZSBpdCBjbGVhcmVy Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGVycm9yMjdAZ21haWwuY29tPgoK UGF0Y2ggYXBwbGllZC4gIFRoYW5rIHlvdS4KLS0gClZpc2l0IE9wZW5zd2FuIGF0IGh0dHA6Ly93 d3cub3BlbnN3YW4ub3JnLwpFbWFpbDogSGVyYmVydCBYdSB+e1BtVj5ISX59IDxoZXJiZXJ0QGdv bmRvci5hcGFuYS5vcmcuYXU+CkhvbWUgUGFnZTogaHR0cDovL2dvbmRvci5hcGFuYS5vcmcuYXUv fmhlcmJlcnQvClBHUCBLZXk6IGh0dHA6Ly9nb25kb3IuYXBhbmEub3JnLmF1L35oZXJiZXJ0L3B1 YmtleS50eHQKLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUg InVuc3Vic2NyaWJlIGtlcm5lbC1qYW5pdG9ycyIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRv IG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDov L3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1s From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [patch] mv_cesa: fixup error handling in mv_probe() Date: Wed, 26 May 2010 10:45:35 +1000 Message-ID: <20100526004535.GF20073@gondor.apana.org.au> References: <20100525094947.GF22515@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S. Miller" , Uri Simchoni , Nicolas Pitre , Tejun Heo , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: Received: from ringil.hengli.com.au ([216.59.3.182]:52063 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758456Ab0EZAp5 (ORCPT ); Tue, 25 May 2010 20:45:57 -0400 Content-Disposition: inline In-Reply-To: <20100525094947.GF22515@bicker> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, May 25, 2010 at 11:49:47AM +0200, Dan Carpenter wrote: > The error handling in mv_probe() was a bit messed up. There were some > gotos to the wrong labels so it ended up releasing stuff that that hadn't > been aquired and not releasing stuff that was meant to be released. I > shuffled it around a bit to fix it and make it clearer. > > Signed-off-by: Dan Carpenter Patch applied. Thank you. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt