From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v4 2/2] atmodem: fix crash during context deactivation
Date: Wed, 26 May 2010 12:37:51 -0500 [thread overview]
Message-ID: <201005261237.51310.denkenz@gmail.com> (raw)
In-Reply-To: <20100526153621.2563.89213.stgit@potku.valot.fi>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
Hi Kalle,
> Ofono either crashed or busy looped with my Huawei E1552 3G modem when I
> tried to deactivate GPRS context. The reason was that gcd->chat was
> unreferenced already in setup_ppp() but the chat was still accessed
> later in at_gprs_deactivate_primary().
>
> To fix the problem, change the logic instead to suspend chat session
> for PPP and resume when PPP has disconnected. Now it doesn't crash
> anymore.
>
> Deactivation still doesn't work properly with Huawei E1552, and most
> probably with other Huawei modems, because the modem hangs up the chat
> line after PPP deactivation. This needs to be fixed separately. The
> workaround is to reboot the modem, for example physically unplug and plug
> it in again.
> ---
Patch has been applied, thanks.
Regards,
-Denis
next prev parent reply other threads:[~2010-05-26 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 15:36 [PATCH v4 1/2] atmodem: remove CGACT command Kalle Valo
2010-05-26 15:36 ` [PATCH v4 2/2] atmodem: fix crash during context deactivation Kalle Valo
2010-05-26 17:37 ` Denis Kenzior [this message]
2010-05-26 16:12 ` [PATCH v4 1/2] atmodem: remove CGACT command Marcel Holtmann
2010-05-26 17:35 ` Kalle Valo
2010-05-26 17:37 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005261237.51310.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.