From: Christoph Hellwig <hch@lst.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Christoph Hellwig <hch@lst.de>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86-32: always use irq stacks
Date: Wed, 26 May 2010 15:00:13 +0200 [thread overview]
Message-ID: <20100526130013.GA641@lst.de> (raw)
In-Reply-To: <alpine.LFD.2.00.1005261446290.2995@localhost.localdomain>
On Wed, May 26, 2010 at 02:47:07PM +0200, Thomas Gleixner wrote:
> On Wed, 26 May 2010, Christoph Hellwig wrote:
>
> >
> > IRQ stacks provide much better safety against unexpected stack use from
> > interrupts, at the minimal downside of slightly higher memory usage.
> > Enable irq stacks also for the default 8k stack to minimize the problem
> > of stack overflows through interrupt activity.
> >
> > This is what x86-64 and various other architectures already do.
>
> We got rid of nested interrupts, so is this really a concern anymore ?
Yes, especially for deep storage stacks anything that can come in
unexpectedly from IRQ context is quite harmful. It's a really cheap
way to avoid that indeterminism.
next prev parent reply other threads:[~2010-05-26 13:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 11:09 [PATCH] x86-32: always use irq stacks Christoph Hellwig
2010-05-26 12:47 ` Thomas Gleixner
2010-05-26 13:00 ` Christoph Hellwig [this message]
2010-06-16 5:16 ` Christoph Hellwig
2010-06-16 5:56 ` Ingo Molnar
2010-06-16 6:27 ` Christoph Hellwig
2010-06-16 7:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526130013.GA641@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.