All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: linux-mtd@lists.infradead.org
Subject: Do we remove from jedec_probe.c?
Date: Wed, 26 May 2010 19:53:20 +0200	[thread overview]
Message-ID: <20100526175320.GD24167@pengutronix.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

Hi,

now that Guillaume introduced cfi-support for some SST-flashes, I wonder if
those can be removed from jedec_probe.c? Or should they stay for
backward-compatibility?

Proposed patch would look like this:

diff --git a/drivers/mtd/chips/jedec_probe.c b/drivers/mtd/chips/jedec_probe.c
index d72a5fb..37fdff3 100644
--- a/drivers/mtd/chips/jedec_probe.c
+++ b/drivers/mtd/chips/jedec_probe.c
@@ -146,8 +146,6 @@
 #define SST29LE512	0x003d
 #define SST39LF800	0x2781
 #define SST39LF160	0x2782
-#define SST39VF1601	0x234b
-#define SST39VF3201	0x235b
 #define SST39WF1601	0x274b
 #define SST39WF1602	0x274a
 #define SST39LF512	0x00D4
@@ -1500,19 +1498,6 @@ static const struct amd_flash_info jedec_table[] = {
 			ERASEINFO(0x1000,256)
 		}
 	}, {
-		.mfr_id		= CFI_MFR_SST,     /* should be CFI */
-		.dev_id		= SST39VF1601,
-		.name		= "SST 39VF1601",
-		.devtypes	= CFI_DEVICETYPE_X16,
-		.uaddr		= MTD_UADDR_0xAAAA_0x5555,
-		.dev_size	= SIZE_2MiB,
-		.cmd_set	= P_ID_AMD_STD,
-		.nr_regions	= 2,
-		.regions	= {
-			ERASEINFO(0x1000,256),
-			ERASEINFO(0x1000,256)
-		}
-	}, {
 		/* CFI is broken: reports AMD_STD, but needs custom uaddr */
 		.mfr_id		= CFI_MFR_SST,
 		.dev_id		= SST39WF1601,
@@ -1541,21 +1526,6 @@ static const struct amd_flash_info jedec_table[] = {
 			ERASEINFO(0x1000,256)
 		}
 	}, {
-		.mfr_id		= CFI_MFR_SST,     /* should be CFI */
-		.dev_id		= SST39VF3201,
-		.name		= "SST 39VF3201",
-		.devtypes	= CFI_DEVICETYPE_X16,
-		.uaddr		= MTD_UADDR_0xAAAA_0x5555,
-		.dev_size	= SIZE_4MiB,
-		.cmd_set	= P_ID_AMD_STD,
-		.nr_regions	= 4,
-		.regions	= {
-			ERASEINFO(0x1000,256),
-			ERASEINFO(0x1000,256),
-			ERASEINFO(0x1000,256),
-			ERASEINFO(0x1000,256)
-		}
-	}, {
 		.mfr_id		= CFI_MFR_SST,
 		.dev_id		= SST36VF3203,
 		.name		= "SST 36VF3203",

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2010-05-26 17:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26 17:53 Wolfram Sang [this message]
2010-06-01  9:55 ` Do we remove from jedec_probe.c? Wolfram Sang
2010-06-01 10:13   ` Guillaume LECERF
2010-06-03 14:44 ` Carl-Daniel Hailfinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100526175320.GD24167@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.