From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm:io.h: define __io() macro if not defined erlier
Date: Wed, 26 May 2010 22:19:04 +0200 [thread overview]
Message-ID: <20100526201904.E671CEAC238@gemini.denx.de> (raw)
In-Reply-To: <201005261350.16464.vapier@gentoo.org>
Dear Mike Frysinger,
In message <201005261350.16464.vapier@gentoo.org> you wrote:
>
> i changed the accessors to use in/out macros as i thought that was the correct
> set of accessor functions to use. looking at a set of definitions and picking
> a set because they look like they'll "just work" isnt how i set about it.
>
> after having read the deviceiobook in the Linux kernel, i think the correct
> funcs to use here are the read/write helpers. now that i have that
> information, looking at the definitions shows that this should work for ARM
> just fine.
>
> so, to be clear, i think we should do:
> -#define DM9000_outb(d,r) outb(d, r)
> +#define DM9000_outb(d,r) writeb(d, r)
> etc...
This seems to work for me.
Will send a patch to do this ASAP.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I am a computer. I am dumber than any human and smarter than any ad-
ministrator.
prev parent reply other threads:[~2010-05-26 20:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 8:57 [U-Boot] [PATCH] arm:io.h: define __io() macro if not defined erlier Andreas Bießmann
2010-05-19 14:34 ` Thomas Weber
2010-05-21 21:07 ` Wolfgang Denk
2010-05-25 8:15 ` Andreas Bießmann
2010-05-25 11:29 ` Wolfgang Denk
2010-05-26 9:49 ` Andreas Bießmann
2010-05-26 17:50 ` Mike Frysinger
2010-05-26 20:19 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526201904.E671CEAC238@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.