From: Sebastien Jan <s-jan@ti.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Add missing extern to heap_free declaration
Date: Wed, 26 May 2010 20:39:09 +0200 [thread overview]
Message-ID: <201005262039.10077.s-jan@ti.com> (raw)
In-Reply-To: <20100526183501.GA14969@x200.telecom.by>
On Wednesday 26 May 2010 20:35:01 Alexey Dobriyan wrote:
> On Wed, May 26, 2010 at 08:28:19PM +0200, Sebastien JAN wrote:
> > heap_free() function is defined in lib/prio_heap.c
> >
> > --- a/include/linux/prio_heap.h
> > +++ b/include/linux/prio_heap.h
> > -void heap_free(struct ptr_heap *heap);
> > +extern void heap_free(struct ptr_heap *heap);
>
> This is totally unneeded.
>
> In fact, externless prototypes are better.
>
The attempt was to have a unified way of declaring the functions in this
file since the other functions have the 'export'.
prev parent reply other threads:[~2010-05-26 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 18:28 [PATCH] Add missing extern to heap_free declaration Sebastien JAN
2010-05-26 18:35 ` Alexey Dobriyan
2010-05-26 18:39 ` Sebastien Jan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005262039.10077.s-jan@ti.com \
--to=s-jan@ti.com \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.