From mboxrd@z Thu Jan 1 00:00:00 1970 From: marek.vasut@gmail.com (Marek Vasut) Date: Wed, 26 May 2010 21:15:57 +0200 Subject: [PATCH] sa1111: Prevent deadlock in resume path In-Reply-To: <20100526191425.GD6232@n2100.arm.linux.org.uk> References: <1274901104-22133-1-git-send-email-marek.vasut@gmail.com> <20100526191425.GD6232@n2100.arm.linux.org.uk> Message-ID: <201005262115.57282.marek.vasut@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dne St 26. kv?tna 2010 21:14:25 Russell King - ARM Linux napsal(a): > On Wed, May 26, 2010 at 09:11:44PM +0200, Marek Vasut wrote: > > This patch reorganises the sa1111_resume() function in a manner the > > spinlock happens after calling the sa1111_wake(). This fixes two bugs: > > > > 1) This function called sa1111_wake() which tried to claim the same > > spinlock > > > > the sa1111_resume() already claimed. This would result in certain > > deadlock. > > > > Original idea for this part: Russell King > > > > 2) The function didn't unlock the spinlock in case the chip didn't report > > > > correct ID. > > > > Original idea for this part: Julia Lawall > > > > Signed-off-by: Marek Vasut > > Yea, good enough. You want me to fight your patch tracking system or will you just merge it into your tree ?