From: Al Viro <viro@ZenIV.linux.org.uk>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Neela Syam Kolli <megaraidlinux@lsi.com>,
scsi <linux-scsi@vger.kernel.org>
Subject: Re: megaraid sparse warnings
Date: Wed, 26 May 2010 22:39:47 +0100 [thread overview]
Message-ID: <20100526213947.GW31073@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100526142802.1c06d5c1.rdunlap@xenotime.net>
On Wed, May 26, 2010 at 02:28:02PM -0700, Randy Dunlap wrote:
> ping??
> > sprintf (adapter->fw_version, "%c%d%d.%d%d",
> > adapter->product_info.fw_version[2],
> > adapter->product_info.fw_version[1] >> 8,
> > adapter->product_info.fw_version[1] & 0x0f,
> > adapter->product_info.fw_version[0] >> 8,
> > adapter->product_info.fw_version[0] & 0x0f);
> > sprintf (adapter->bios_version, "%c%d%d.%d%d",
> > adapter->product_info.bios_version[2],
> > adapter->product_info.bios_version[1] >> 8,
> > adapter->product_info.bios_version[1] & 0x0f,
> > adapter->product_info.bios_version[0] >> 8,
> > adapter->product_info.bios_version[0] & 0x0f);
> > } else {
> > Are the fw_version and bios_version fields more than 8 bits each for HP subsys VID
> > products? Do HP VID products need a different struct so that they print this info
> > correctly?
Since both are claimed to be strings, I really suspect that this >> 8 is
misspelled >> 4 and they have a character followed by pair of two-digit
packed decimals in there...
next prev parent reply other threads:[~2010-05-26 21:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 5:23 megaraid sparse warnings Randy Dunlap
2010-05-26 21:28 ` Randy Dunlap
2010-05-26 21:39 ` Al Viro [this message]
2010-05-26 22:00 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526213947.GW31073@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux@lsi.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.