From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sa1111: Prevent deadlock in resume path
Date: Wed, 26 May 2010 23:33:46 +0200 [thread overview]
Message-ID: <201005262333.47046.marek.vasut@gmail.com> (raw)
In-Reply-To: <20100526201824.GA16418@n2100.arm.linux.org.uk>
Dne St 26. kv?tna 2010 22:18:24 Russell King - ARM Linux napsal(a):
> On Wed, May 26, 2010 at 09:15:57PM +0200, Marek Vasut wrote:
> > Dne St 26. kv?tna 2010 21:14:25 Russell King - ARM Linux napsal(a):
> > > On Wed, May 26, 2010 at 09:11:44PM +0200, Marek Vasut wrote:
> > > > This patch reorganises the sa1111_resume() function in a manner the
> > > > spinlock happens after calling the sa1111_wake(). This fixes two
> > > > bugs:
> > > >
> > > > 1) This function called sa1111_wake() which tried to claim the same
> > > > spinlock
> > > >
> > > > the sa1111_resume() already claimed. This would result in certain
> > > > deadlock.
> > > >
> > > > Original idea for this part: Russell King <linux@arm.linux.org.uk>
> > > >
> > > > 2) The function didn't unlock the spinlock in case the chip didn't
> > > > report
> > > >
> > > > correct ID.
> > > >
> > > > Original idea for this part: Julia Lawall <julia@diku.dk>
> > > >
> > > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > >
> > > Yea, good enough.
> >
> > You want me to fight your patch tracking system or will you just merge it
> > into your tree ?
>
> What do you mean "fight" ? Just send a standard git formatted patch
> to the email address with an additional KernelVersion: tag. It's
> not at all hard.
What address, how, any howto?
btw. why ?! Look at Eric, he doesn't need such crap, why do you complicate it so
much ?
next prev parent reply other threads:[~2010-05-26 21:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 19:11 [PATCH] sa1111: Prevent deadlock in resume path Marek Vasut
2010-05-26 19:14 ` Russell King - ARM Linux
2010-05-26 19:15 ` Marek Vasut
2010-05-26 20:18 ` Russell King - ARM Linux
2010-05-26 21:33 ` Marek Vasut [this message]
2010-05-26 21:42 ` Russell King - ARM Linux
2010-05-26 21:52 ` Marek Vasut
2010-05-26 22:25 ` Russell King - ARM Linux
2010-05-26 22:35 ` Marek Vasut
2010-05-27 3:49 ` Nicolas Pitre
2010-06-10 13:56 ` Pavel Machek
2010-06-10 13:56 ` Pavel Machek
2010-06-10 21:49 ` Marek Vasut
2010-06-10 21:49 ` Marek Vasut
2010-06-10 23:05 ` Russell King - ARM Linux
2010-06-10 23:05 ` Russell King - ARM Linux
2010-06-11 12:22 ` Catalin Marinas
2010-06-11 12:22 ` Catalin Marinas
2010-06-12 5:36 ` Eric Miao
2010-06-12 5:36 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005262333.47046.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.