From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH 02/11] drm/i915: Hold the spinlock whilst
 resetting unpin_work along error path
Date: Thu, 27 May 2010 09:03:02 -0700
Message-ID: <20100527090302.0e5a878e@virtuousgeek.org>
References: <1274962702-6530-1-git-send-email-chris@chris-wilson.co.uk>
	<1274962702-6530-3-git-send-email-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from outbound-mail-01.bluehost.com (cpoproxy1-pub.bluehost.com
	[69.89.21.11])
	by gabe.freedesktop.org (Postfix) with SMTP id 85EC59E8F9
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 27 May 2010 09:03:25 -0700 (PDT)
In-Reply-To: <1274962702-6530-3-git-send-email-chris@chris-wilson.co.uk>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCAyNyBNYXkgMjAxMCAxMzoxODoxMyArMDEwMApDaHJpcyBXaWxzb24gPGNocmlzQGNo
cmlzLXdpbHNvbi5jby51az4gd3JvdGU6Cgo+IERlbGF5IHRha2luZyB0aGUgbXV0ZXggdW50aWwg
d2UgbmVlZCB0byBhbmQgZW5zdXJlIHRoYXQgd2UgaG9sZCB0aGUKPiBzcGlubG9jayB3aGVuIHJl
c2V0dGluZyB1bnBpbl93b3JrIG9uIHRoZSBlcnJvciBwYXRoLiBBbHNvIGRlZmVyIHRoZQo+IGRl
YnVnZ2luZyBwcmludCBtZXNzYWdlcyB1bnRpbCBhZnRlciB3ZSBoYXZlIHJlbGVhc2VkIHRoZSBz
cGlubG9jay4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp
bHNvbi5jby51az4KPiBDYzogSmVzc2UgQmFybmVzIDxqYmFybmVzQHZpcnR1b3VzZ2Vlay5vcmc+
Cj4gQ2M6IEtyaXN0aWFuIEjDuGdzYmVyZyA8a3JoQGJpdHBsYW5ldC5uZXQ+Cj4gLS0tCj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8ICAgMjAgKysrKysrKysrKysrLS0t
LS0tLS0KPiAgMSBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygt
KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBpbmRleCBjZmFjNGRkLi4x
ODQ1YTA2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku
Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC00NjY3
LDggKzQ2NjcsNiBAQCBzdGF0aWMgaW50IGludGVsX2NydGNfcGFnZV9mbGlwKHN0cnVjdCBkcm1f
Y3J0YyAqY3J0YywKPiAgCWlmICh3b3JrID09IE5VTEwpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4g
IAo+IC0JbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IC0KPiAgCXdvcmstPmV2ZW50
ID0gZXZlbnQ7Cj4gIAl3b3JrLT5kZXYgPSBjcnRjLT5kZXY7Cj4gIAlpbnRlbF9mYiA9IHRvX2lu
dGVsX2ZyYW1lYnVmZmVyKGNydGMtPmZiKTsKPiBAQCAtNDY3OCwxMCArNDY3NiwxMCBAQCBzdGF0
aWMgaW50IGludGVsX2NydGNfcGFnZV9mbGlwKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCS8q
IFdlIGJvcnJvdyB0aGUgZXZlbnQgc3BpbiBsb2NrIGZvciBwcm90ZWN0aW5nIHVucGluX3dvcmsg
Ki8KPiAgCXNwaW5fbG9ja19pcnFzYXZlKCZkZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKPiAgCWlm
IChpbnRlbF9jcnRjLT51bnBpbl93b3JrKSB7Cj4gLQkJRFJNX0RFQlVHX0RSSVZFUigiZmxpcCBx
dWV1ZTogY3J0YyBhbHJlYWR5IGJ1c3lcbiIpOwo+ICAJCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUo
JmRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+ICAJCWtmcmVlKHdvcmspOwo+IC0JCW11dGV4X3Vu
bG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsKPiArCQlEUk1fREVCVUdfRFJJVkVSKCJmbGlw
IHF1ZXVlOiBjcnRjIGFscmVhZHkgYnVzeVxuIik7Cj4gIAkJcmV0dXJuIC1FQlVTWTsKPiAgCX0K
PiAgCWludGVsX2NydGMtPnVucGluX3dvcmsgPSB3b3JrOwo+IEBAIC00NjkwLDEzICs0Njg4LDE5
IEBAIHN0YXRpYyBpbnQgaW50ZWxfY3J0Y19wYWdlX2ZsaXAoc3RydWN0IGRybV9jcnRjICpjcnRj
LAo+ICAJaW50ZWxfZmIgPSB0b19pbnRlbF9mcmFtZWJ1ZmZlcihmYik7Cj4gIAlvYmogPSBpbnRl
bF9mYi0+b2JqOwo+ICAKPiArCW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAgCXJl
dCA9IGludGVsX3Bpbl9hbmRfZmVuY2VfZmJfb2JqKGRldiwgb2JqKTsKPiAgCWlmIChyZXQgIT0g
MCkgewo+IC0JCURSTV9ERUJVR19EUklWRVIoImZsaXAgcXVldWU6ICVwIHBpbiAmIGZlbmNlIGZh
aWxlZFxuIiwKPiAtCQkJICB0b19pbnRlbF9ibyhvYmopKTsKPiAtCQlrZnJlZSh3b3JrKTsKPiAt
CQlpbnRlbF9jcnRjLT51bnBpbl93b3JrID0gTlVMTDsKPiAgCQltdXRleF91bmxvY2soJmRldi0+
c3RydWN0X211dGV4KTsKPiArCj4gKwkJc3Bpbl9sb2NrX2lycXNhdmUoJmRldi0+ZXZlbnRfbG9j
aywgZmxhZ3MpOwo+ICsJCWludGVsX2NydGMtPnVucGluX3dvcmsgPSBOVUxMOwo+ICsJCXNwaW5f
dW5sb2NrX2lycXJlc3RvcmUoJmRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+ICsKPiArCQlrZnJl
ZSh3b3JrKTsKPiArCj4gKwkJRFJNX0RFQlVHX0RSSVZFUigiZmxpcCBxdWV1ZTogJXAgcGluICYg
ZmVuY2UgZmFpbGVkXG4iLAo+ICsJCQkJIHRvX2ludGVsX2JvKG9iaikpOwo+ICAJCXJldHVybiBy
ZXQ7Cj4gIAl9CgpUaGUgbXV0ZXggY2hhbmdlIGxvb2tzIGxpa2UgYSBnb29kIGNsZWFudXAsIGFu
ZCB0aGUgc3BpbiBsb2NrIGFkZGl0aW9uCmlzIGEgZ29vZCBmaXguICBUaGFua3MuCgpSZXZpZXdl
ZC1ieTogSmVzc2UgQmFybmVzIDxqYmFybmVzQHZpcnR1b3VzZ2Vlay5vcmc+CgotLSAKSmVzc2Ug
QmFybmVzLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0
CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w
Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=