All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 1/4] Add: Online property to modem
Date: Thu, 27 May 2010 09:45:53 -0500	[thread overview]
Message-ID: <201005270945.53526.denkenz@gmail.com> (raw)
In-Reply-To: <AANLkTikQJ6AooO-z3IUNthX_d9IlXffpaZKI1XXT18xZ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]

Hi Pekka,

> 2010/5/27 Denis Kenzior <denkenz@gmail.com>:
> > Patch has been applied, however I did some refactoring afterward.  Please
> > test that I didn't break something.
> 
> There is now a race condition in online/offline and sim hotswap. With
> imperfect hw a missing sim gets detected only when modem attempts to
> register to network and actually tries to read something from sim
> card. I have no idea if the missing sim can be reported before +cops
> command response is returned.

Sorry, but how does such a modem even get to the sim ready state?  oFono reads 
the IMSI before it even tries to send post_sim, and you certainly can't read 
the IMSI without a sim card.

Or are you talking about an emergency call case here?

> 
> However, at least isimodem needs explicitly told to go offline when
> sim gets removed.
> 

My thinking is that the modem drivers can take care of this.  The core needs 
to be kept simple here and assume an 'ideal' implementation.

I'm still having trouble understanding how we'll support emergency calls with 
no SIM with this framework though.

Regards,
-Denis

  reply	other threads:[~2010-05-27 14:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-25 21:14 [PATCH 1/4] Add: Online property to modem Pekka Pessi
2010-05-25 21:14 ` [PATCH 2/4] Add: test scripts online-modem and offline-modem Pekka Pessi
2010-05-25 21:14   ` [PATCH 3/4] Add: set_online and post_online methods to isimodem driver Pekka Pessi
2010-05-25 21:14     ` [PATCH 4/4] Add description of Online property to modem-api.txt Pekka Pessi
2010-05-27  2:05       ` Denis Kenzior
2010-05-27  2:05   ` [PATCH 2/4] Add: test scripts online-modem and offline-modem Denis Kenzior
2010-05-26 14:58 ` [PATCH 1/4] Add: Online property to modem Pekka Pessi
2010-05-27  2:05   ` Denis Kenzior
2010-05-27 13:05     ` Pekka Pessi
2010-05-27 14:45       ` Denis Kenzior [this message]
2010-05-27 15:14         ` Pekka Pessi
2010-05-27 15:34           ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005270945.53526.denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.