All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
	davem@davemloft.net, jens.axboe@oracle.com,
	linux-kernel@vger.kernel.org, torvalds@osdl.org,
	viro@ZenIV.linux.org.uk, akpm@linux-foundation.org
Subject: Re: [PATCH] fs: run emergency remount on dedicated workqueue
Date: Thu, 27 May 2010 22:59:11 +0800	[thread overview]
Message-ID: <20100527145807.GB3600@hack> (raw)
In-Reply-To: <4BFE4203.5010803@kernel.org>

On Thu, May 27, 2010 at 11:57:23AM +0200, Tejun Heo wrote:
>Commit fa4b9074cd8428958c2adf9dc0c831f46e27c193 made s_umount depend
>on keventd; however, emergency remount schedules works to keventd
>which grabs s_umount creating a circular dependency.  Run emergency
>remount on a separate workqueue to break it.
>


I have a stupid question, why using workqueue instead of
calling do_remount_sb() directly in emergency_remount()?
Avoid blocking emergency_remount()?

Thanks.

-- 
Live like a child, think like the god.
 

  reply	other threads:[~2010-05-27 14:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-26 15:01 Change to invalidate_bdev() may break emergency remount R/O David Howells
2010-05-27  9:57 ` [PATCH] fs: run emergency remount on dedicated workqueue Tejun Heo
2010-05-27 14:59   ` Américo Wang [this message]
2010-05-27 17:03     ` Tejun Heo
2010-05-28  6:46       ` Américo Wang
2010-06-01 23:46   ` Andrew Morton
2010-06-01 23:57     ` Linus Torvalds
2010-06-02  0:13       ` Tejun Heo
2010-06-02  1:02     ` Dave Young
2010-06-02  1:57       ` Andrew Morton
2010-06-02  1:57         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100527145807.GB3600@hack \
    --to=xiyou.wangcong@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=torvalds@osdl.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.