From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: Erik van der Kouwe <vdkouwe@cs.vu.nl>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Fam Zheng <famcool@gmail.com>
Subject: Re: [PATCH] fs/minix: bugfix, number of indirect block ptrs per block depends on block size
Date: Thu, 27 May 2010 17:01:14 +0100 [thread overview]
Message-ID: <20100527160114.GH31073@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100526215442.GB3316@quack.suse.cz>
On Wed, May 26, 2010 at 11:54:43PM +0200, Jan Kara wrote:
> > - } else if ((block -= 7) < 256) {
> > - offsets[n++] = 7;
> > + } else if ((block -= DIRCOUNT) < INDIRCOUNT(sb)) {
> This modification of 'block' in the if condition is a blatant violation
> of the kernel coding style.
The hell it is. [...said the guy who'd written it that way in the first place]
It _is_ idiomatic C for that kind of thing ("we've got several adjacent ranges,
find which one had we hit and how far from its start").
next prev parent reply other threads:[~2010-05-27 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 10:03 [PATCH] fs/minix: bugfix, number of indirect block ptrs per block depends on block size Erik van der Kouwe
2010-05-26 21:54 ` Jan Kara
2010-05-27 16:01 ` Al Viro [this message]
2010-05-27 17:11 ` Erik van der Kouwe
2010-05-27 17:17 ` Jan Kara
2010-05-27 4:35 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100527160114.GH31073@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=famcool@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vdkouwe@cs.vu.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.