All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Langer <an.langer@gmx.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] Layer 2 fragmentation
Date: Thu, 27 May 2010 16:23:50 +0200	[thread overview]
Message-ID: <20100527162350.75bef379@rechenknecht> (raw)

Hello,
i looked into the problem of fragmenting packets on layer2 to solve the mtu issue. I found a
unforeseen problem : oversized packets will be dropped by the bridge module ( if bat0 is in a
bridge ). I think the reason can be found here net/bridge/br_forward.c on line 44

43         /* drop mtu oversized packets except gso */
44         if (packet_length(skb) > skb->dev->mtu && !skb_is_gso(skb))
45                 kfree_skb(skb);

Possible solution: make a patch for the bridge module

if (packet_length(skb) > skb->dev->mtu && !skb_is_gso(skb) && !(skb->dev->priv_flags &
IFF_CAN_FRAG))

IFF_CAN_FRAG must be added to include/linux/if.h and batman-adv has to set this flag on bat0

I can make a patch for mainline inclusion, do you believe it is going to be accepted ?

regards, 
andreas

             reply	other threads:[~2010-05-27 14:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27 14:23 Andreas Langer [this message]
2010-05-27 15:07 ` [B.A.T.M.A.N.] Layer 2 fragmentation Andrew Lunn
2010-05-27 15:30   ` Marek Lindner
2010-05-27 15:42     ` Andrew Lunn
2010-05-27 16:12       ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100527162350.75bef379@rechenknecht \
    --to=an.langer@gmx.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.