All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Herrmann <herrmann.der.user@googlemail.com>
To: Jerone Young <jerone.young@canonical.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org,
	Borislav Petkov <borislav.petkov@amd.com>
Subject: Re: [PATCH] ALSA, hda: Add support for Lenovo ThinkPad Edge 13 in conexant codec
Date: Fri, 28 May 2010 08:21:02 +0200	[thread overview]
Message-ID: <20100528062102.GF10254@alberich.amd.com> (raw)
In-Reply-To: <s5htyps3788.wl%tiwai@suse.de>

On Fri, May 28, 2010 at 07:50:31AM +0200, Takashi Iwai wrote:
> At Thu, 27 May 2010 18:06:56 +0200,
> Andreas Herrmann wrote:
> > 
> > From: Andreas Herrmann <andreas.herrmann3@amd.com>
> > 
> > On a Thinkpad Edge 13 I had the problem that speakers played sound
> > although headphones were plugged.
> > 
> > Using "model=olpc-xo-1_5" solved this problem. So it seems sensible to
> > add this quirk. (Using other models, like ideabad did not fix it.)
> > 
> > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> > ---
> >  sound/pci/hda/patch_conexant.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > I don't know whether adding this quirk is the right/complete solution
> > to support sound on Thinkpad Edge. But at least it solves this
> > annoying problem.
> 
> Well, Jerone Young already sent a quirk patch but he took
> model=ideapd.  Could you guys check which one is really better?

Hi Jerone,

there are two different models of Thinkpad Edge (one with Intel CPU/chipset,
one with AMD CPU/chipset). I tested on the AMD version but from

https://bugs.launchpad.net/ubuntu/+source/linux-backports-modules-2.6.32/+bug/549289

it seems that using  model=olpc-xo-1_5 works for both versions of that Thinkpad.

I also tried ideapad -- because looking at the quirk table
for cxt5066 there is this entry

        SND_PCI_QUIRK(0x17aa, 0x21b2, "Thinkpad X100e", CXT5066_IDEAPAD),

and adding 

        SND_PCI_QUIRK(0x17aa, 0x21b3, "Thinkpad Edge", CXT5066_IDEAPAD),

seems to be conclusive.

But as I said that did not solve the problem of speakers still playing
audio if headphones are plugged in for me. Have you explicitely tested
this?  Maybe I have to retest with some newer code from the alsa tree?


Regards,
Andreas

  parent reply	other threads:[~2010-05-28  6:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20100527160656.GE10254@alberich.amd.com>
2010-05-28  5:50 ` [PATCH] ALSA, hda: Add support for Lenovo ThinkPad Edge 13 in conexant codec Takashi Iwai
2010-05-28  6:02   ` Jerone Young
2010-05-28  6:21   ` Andreas Herrmann [this message]
2010-05-28  6:35     ` Jerone Young
2010-05-28  6:45       ` Andreas Herrmann
2010-05-28  7:57 ` [PATCH] ALSA, hda: Add support for another Lenovo ThinkPad Edge " Andreas Herrmann
2010-05-28  8:04   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100528062102.GF10254@alberich.amd.com \
    --to=herrmann.der.user@googlemail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=borislav.petkov@amd.com \
    --cc=jerone.young@canonical.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.