From: Philipp Reisner <philipp.reisner@linbit.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] drbd sparse warnings
Date: Fri, 28 May 2010 10:07:11 +0200 [thread overview]
Message-ID: <201005281007.11478.philipp.reisner@linbit.com> (raw)
In-Reply-To: <20100526190403.fcf8d536.rdunlap@xenotime.net>
Am Donnerstag, 27. Mai 2010, um 04:04:03 schrieb Randy Dunlap:
> Hi,
>
> When I build a Linux kernel with "make C=1" to invoke sparse,
> I see 135 sparse warnings like (shorter list):
>
>
> linux-2.6.34-git11/drivers/block/drbd/drbd_int.h:931:39: error: attribute 'require_context': unknown attribute
> linux-2.6.34-git11/drivers/block/drbd/drbd_int.h:1212:69: error: attribute 'require_context': unknown attribute
[...]
We have a patched sparse here.
I tried to get those improvements into sparse upstream, but
at that time the sparse maintainer was not very active...
http://marc.info/?l=linux-sparse&m=120696665813430&w=4
>
> What is the meaning and usage of require_context in drbd_int.h?
>
I guess I will remove that stuff from DRBD in Linux mainline.
Or someone steps up, and helps to get those sparse improvements
into sparse ;)
Best,
Phil
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
prev parent reply other threads:[~2010-05-28 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 2:04 [Drbd-dev] drbd sparse warnings Randy Dunlap
2010-05-28 8:07 ` Philipp Reisner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005281007.11478.philipp.reisner@linbit.com \
--to=philipp.reisner@linbit.com \
--cc=drbd-dev@lists.linbit.com \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.