From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 11/11] Style corrections.
Date: Fri, 28 May 2010 12:20:07 -0500 [thread overview]
Message-ID: <201005281220.07678.denkenz@gmail.com> (raw)
In-Reply-To: <1274957690-4893-11-git-send-email-pasi.miettinen@ixonos.com>
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
Hi Pasi,
> From: Pasi Miettinen <pasi.miettinen@ixonos.com>
>
> ---
> src/sms.c | 25 ++++++++++++++-----------
> 1 files changed, 14 insertions(+), 11 deletions(-)
>
Style correction patches for code introduced in the same series should simply
be squished into the previous changes. This makes it much easier for us to
review. e.g. this patch should not exist and any corrections made to the
patches that originally introduced the code.
Regards,
-Denis
next prev parent reply other threads:[~2010-05-28 17:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 10:54 [PATCH 01/11] In drivers/atmodem/sms.c:at_cmgl_cpms_cb() there is a temporary fix for Siemens TC65. If AT+CMGL=4 is sent to TC65, the AT command queue jams pasi.miettinen
2010-05-27 10:54 ` [PATCH 02/11] Made needed changes to at_cds_notify() for status report and corrected at_cmgl_cpms_cb() to meet the ISO standard pasi.miettinen
2010-05-27 10:54 ` [PATCH 03/11] Enable status report pasi.miettinen
2010-05-27 10:54 ` [PATCH 04/11] Changes for SMS statur report pasi.miettinen
2010-05-27 10:54 ` [PATCH 05/11] Added message delivery time to dbus message pasi.miettinen
2010-05-27 10:54 ` [PATCH 06/11] Made it possible to ask for status report via SendMessage method parameters. True=status report on, false=off pasi.miettinen
2010-05-27 10:54 ` [PATCH 07/11] Removed Siemens TC65 specific code pasi.miettinen
2010-05-27 10:54 ` [PATCH 08/11] Some style corrections pasi.miettinen
2010-05-27 10:54 ` [PATCH 09/11] Support for concatenated SMS status report. And ofono_history_sms is now updated according to received status reports pasi.miettinen
2010-05-27 10:54 ` [PATCH 10/11] Some naming changes to enum sms_status_report_result pasi.miettinen
2010-05-27 10:54 ` [PATCH 11/11] Style corrections pasi.miettinen
2010-05-28 17:20 ` Denis Kenzior [this message]
2010-05-28 17:26 ` [PATCH 09/11] Support for concatenated SMS status report. And ofono_history_sms is now updated according to received status reports Denis Kenzior
2010-05-31 12:33 ` VS: " Miettinen Pasi
2010-05-31 16:18 ` Denis Kenzior
2010-05-28 17:15 ` [PATCH 07/11] Removed Siemens TC65 specific code Denis Kenzior
2010-05-27 11:32 ` [PATCH 06/11] Made it possible to ask for status report via SendMessage method parameters. True=status report on, false=off Aki Niemi
2010-05-27 11:39 ` Marcel Holtmann
2010-05-27 11:56 ` Aki Niemi
2010-06-09 22:21 ` Inaky Perez-Gonzalez
2010-06-09 22:47 ` Denis Kenzior
2010-06-09 23:29 ` Inaky Perez-Gonzalez
2010-06-10 1:11 ` Marcel Holtmann
2010-05-27 11:51 ` Denis Kenzior
2010-05-27 13:19 ` Marcel Holtmann
2010-05-28 9:08 ` VS: " Miettinen Pasi
2010-05-28 17:34 ` Denis Kenzior
2010-05-27 11:41 ` [PATCH 04/11] Changes for SMS statur report Aki Niemi
2010-05-28 12:02 ` VS: " Miettinen Pasi
2010-05-28 17:12 ` Denis Kenzior
2010-05-28 16:56 ` [PATCH 03/11] Enable status report Denis Kenzior
2010-05-28 16:55 ` [PATCH 02/11] Made needed changes to at_cds_notify() for status report and corrected at_cmgl_cpms_cb() to meet the ISO standard Denis Kenzior
2010-05-28 16:48 ` [PATCH 01/11] In drivers/atmodem/sms.c:at_cmgl_cpms_cb() there is a temporary fix for Siemens TC65. If AT+CMGL=4 is sent to TC65, the AT command queue jams Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005281220.07678.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.