From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Date: Fri, 28 May 2010 19:25:30 +0000 Subject: Re: [patch] hotplug/shpchp_hpc: add parenthesis in Message-Id: <20100528122530.7e4dbc46@virtuousgeek.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Wed, 26 May 2010 12:46:39 +0200 Dan Carpenter wrote: > The SLOT_REG_RSVDZ_MASK macro is normally used like this: > slot_reg &= ~SLOT_REG_RSVDZ_MASK; > The ~ operator has higher precedence than the | operator from inside the > macro, so it needs parenthesis. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c > index 5f5e8d2..d3985e7 100644 > --- a/drivers/pci/hotplug/shpchp_hpc.c > +++ b/drivers/pci/hotplug/shpchp_hpc.c > @@ -113,7 +113,7 @@ > #define CON_PFAULT_INTR_MASK (1 << 28) > #define MRL_CHANGE_SERR_MASK (1 << 29) > #define CON_PFAULT_SERR_MASK (1 << 30) > -#define SLOT_REG_RSVDZ_MASK (1 << 15) | (7 << 21) > +#define SLOT_REG_RSVDZ_MASK ((1 << 15) | (7 << 21)) > > /* > * SHPC Command Code definitnions Applied to my for-linus branch, thanks. -- Jesse Barnes, Intel Open Source Technology Center