From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, paulus@samba.org, davem@davemloft.net,
fweisbec@gmail.com, perfmon2-devel@lists.sf.net,
eranian@gmail.com, tzanussi@gmail.com,
Arun Sharma <aruns@google.com>
Subject: Re: [PATCH] perf: make perf report -D print sampled CPU
Date: Fri, 28 May 2010 09:57:29 -0300 [thread overview]
Message-ID: <20100528125728.GP9874@ghostprotocols.net> (raw)
In-Reply-To: <4bff964c.e88cd80a.3106.7d31@mx.google.com>
Em Fri, May 28, 2010 at 12:08:01PM +0200, Stephane Eranian escreveu:
> It is useful to know on which CPU a sample was captured on.
> The information is captured with perf record -R but it was
> not printed out by perf report -D. This patch adds this.
>
> When -R is not used, cpu is set to -1to indicate that
> the CPU is unknown (it is not captured).
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
It conflicts with Arun's patch for sorting by CPU that I started playing with
yesterday, but in a good way, i.e. printing the CPU at that dump_printf spot
was one of the changs I made in Arun's patch as well.
[root@emilia linux-2.6-tip]# perf report -D | grep SAMPLE | head -6
0x10240 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 2 17252/17252: 0xffffffff81253362 period: 1894446
0x10268 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 2 17252/17252: 0xffffffff81253338 period: 1894446
0x10290 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 2 17252/17252: 0xffffffff8125300d period: 1905103
0x102b8 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 0 0/0: 0xffffffff8109117d period: 1838260
0x102e0 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 0 293/293: 0xffffffff8101ace6 period: 352697
0x10308 [0x28]: PERF_RECORD_SAMPLE(IP, 1): 0 1763/1763: 0xffffffff8101ace6 period: 352697
[root@emilia linux-2.6-tip]#
I added it just before the pid/tid but prefixing it with "cpu: " is as good as
doing it that way.
I'm applying both patches after some tests,
Thanks!
- Arnaldo
next prev parent reply other threads:[~2010-05-28 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 10:08 [PATCH] perf: make perf report -D print sampled CPU Stephane Eranian
2010-05-28 12:57 ` Arnaldo Carvalho de Melo [this message]
2010-05-28 13:03 ` Stephane Eranian
2010-05-28 13:37 ` Arnaldo Carvalho de Melo
2010-05-28 13:44 ` Stephane Eranian
2010-05-28 14:43 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528125728.GP9874@ghostprotocols.net \
--to=acme@infradead.org \
--cc=aruns@google.com \
--cc=davem@davemloft.net \
--cc=eranian@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=perfmon2-devel@lists.sf.net \
--cc=peterz@infradead.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.