From: Al Viro <viro@ZenIV.linux.org.uk>
To: Theodore Tso <tytso@MIT.EDU>
Cc: Christoph Hellwig <hch@lst.de>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] drop unused dentry argument to ->fsync
Date: Fri, 28 May 2010 14:18:44 +0100 [thread overview]
Message-ID: <20100528131844.GJ31073@ZenIV.linux.org.uk> (raw)
In-Reply-To: <BDF01945-2F0B-471A-B69B-F2B5B7BAF72D@mit.edu>
On Fri, May 28, 2010 at 08:35:26AM -0400, Theodore Tso wrote:
>
> On May 28, 2010, at 7:42 AM, tytso@mit.edu wrote:
>
> > On Wed, May 26, 2010 at 05:53:25PM +0200, Christoph Hellwig wrote:
> >> Signed-off-by: Christoph Hellwig <hch@lst.de>
> >>
> >> Index: linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
> >> ===================================================================
> >> --- linux-2.6.orig/arch/powerpc/platforms/cell/spufs/file.c 2010-05-25 19:28:04.965004819 +0200
> >> +++ linux-2.6/arch/powerpc/platforms/cell/spufs/file.c 2010-05-25 19:55:33.804006007 +0200
> >> @@ -1849,8 +1849,7 @@ out:
> >> return ret;
> >> }
> >>
> >> -static int spufs_mfc_fsync(struct file *file, struct dentry *dentry,
> >> - int datasync)
> >> +static int spufs_mfc_fsync(struct file *file int datasync)
> > ^^^^^
> > Typo: Missing comma, this won't compile.
>
> Oops, looks like emacs in tty mode (when fired from mutt) screwed up my screen, and I saw something quite different from what you posted. Sorry about that, please ignore.
No, you are right, it's a typo; I've caught two more (ntfs and ocfs2, IIRC),
but actually missed that one.
next prev parent reply other threads:[~2010-05-28 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 15:53 [PATCH 1/2] drop unused dentry argument to ->fsync Christoph Hellwig
2010-05-28 11:42 ` tytso
2010-05-28 12:35 ` Theodore Tso
2010-05-28 13:18 ` Al Viro [this message]
2010-05-28 13:50 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528131844.GJ31073@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@MIT.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.