From: Gleb Natapov <gleb@redhat.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: seabios@seabios.org, QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [SeaBIOS] SMBIOS strings
Date: Fri, 28 May 2010 18:44:02 +0300 [thread overview]
Message-ID: <20100528154402.GB3604@redhat.com> (raw)
In-Reply-To: <4BFFE03F.40606@redhat.com>
On Fri, May 28, 2010 at 05:24:47PM +0200, Jes Sorensen wrote:
> I guess the Socket Designation in particular might have been done for a
> reason?
>
It was part of commit cf2affa6de. And was a result of moving to
snprintf() instead of direct string manipulation. Before that
string was created like that:
memcpy((char *)start, "CPU " "\0" "" "\0" "", 7);
((char *)start)[4] = cpu_number + '0';
Which start to produce strange cpu numbers for cpus greater then 9. I
doubt we want to go back to that ;)
--
Gleb.
next prev parent reply other threads:[~2010-05-28 15:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 15:24 [Qemu-devel] SMBIOS strings Jes Sorensen
2010-05-28 15:44 ` Gleb Natapov [this message]
2010-05-31 7:32 ` [Qemu-devel] Re: [SeaBIOS] " Jes Sorensen
2010-05-31 7:50 ` Gleb Natapov
2010-05-31 20:38 ` Sebastian Herbszt
2010-06-01 5:34 ` Markus Armbruster
2010-06-01 6:05 ` Jes Sorensen
2010-06-01 23:57 ` [SeaBIOS] [Qemu-devel] " Kevin O'Connor
2010-06-01 13:02 ` Olivier Galibert
2010-06-01 5:36 ` [Qemu-devel] Re: [SeaBIOS] " Gleb Natapov
2010-05-29 12:49 ` Sebastian Herbszt
2010-05-31 7:33 ` Jes Sorensen
2010-05-29 16:15 ` Kevin O'Connor
2010-06-01 20:26 ` Sebastian Herbszt
2010-06-01 23:34 ` Kevin O'Connor
2010-06-02 20:35 ` Sebastian Herbszt
2010-06-02 6:44 ` Jes Sorensen
2010-06-02 21:01 ` Sebastian Herbszt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528154402.GB3604@redhat.com \
--to=gleb@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.