All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Lars Munch <lars@segv.dk>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] arm: prevent coprocessor IO reset
Date: Fri, 28 May 2010 21:25:45 +0200	[thread overview]
Message-ID: <20100528192545.GD4621@ohm.aurel32.net> (raw)
In-Reply-To: <1273351363-9864-1-git-send-email-lars@segv.dk>

On Sat, May 08, 2010 at 10:42:43PM +0200, Lars Munch wrote:
> This prevent coprocessor IO structure from being reset on cpu reset. This was
> a problem for PXA which uses coprocessor 6 and 14.
> 
> Signed-off-by: Lars Munch <lars@segv.dk>

Thanks, applied.

> ---
>  target-arm/cpu.h |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index 1e34541..f3d138d 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -148,13 +148,6 @@ typedef struct CPUARMState {
>          int pending_exception;
>      } v7m;
>  
> -    /* Coprocessor IO used by peripherals */
> -    struct {
> -        ARMReadCPFunc *cp_read;
> -        ARMWriteCPFunc *cp_write;
> -        void *opaque;
> -    } cp[15];
> -
>      /* Thumb-2 EE state.  */
>      uint32_t teecr;
>      uint32_t teehbr;
> @@ -204,6 +197,13 @@ typedef struct CPUARMState {
>      CPU_COMMON
>  
>      /* These fields after the common ones so they are preserved on reset.  */
> +
> +    /* Coprocessor IO used by peripherals */
> +    struct {
> +        ARMReadCPFunc *cp_read;
> +        ARMWriteCPFunc *cp_write;
> +        void *opaque;
> +    } cp[15];
>      void *nvic;
>      struct arm_boot_info *boot_info;
>  } CPUARMState;
> -- 
> 1.7.1
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

      reply	other threads:[~2010-05-28 19:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-08 20:42 [Qemu-devel] [PATCH] arm: prevent coprocessor IO reset Lars Munch
2010-05-28 19:25 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100528192545.GD4621@ohm.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=lars@segv.dk \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.