From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [Patch 1/4] intel scu ipc Date: Fri, 28 May 2010 19:51:33 +0100 Message-ID: <20100528195133.708ab02c@linux.intel.com> References: <0AE3E14D83C76F4994657326177D1FF9042CE9F49C@bgsmsx501.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mga05.intel.com ([192.55.52.89]:50860 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753412Ab0E1Tgm (ORCPT ); Fri, 28 May 2010 15:36:42 -0400 In-Reply-To: <0AE3E14D83C76F4994657326177D1FF9042CE9F49C@bgsmsx501.gar.corp.intel.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: "Ds, Sreedhara" Cc: "platform-driver-x86@vger.kernel.org" , "mjg@redhat.com" , "x86@kernel.org" On Fri, 28 May 2010 14:09:39 +0530 "Ds, Sreedhara" wrote: > Hello, > Please review and accept the patch > > > From 443010eead6d69e3b60b460fd3f82344de95da5d Mon Sep 17 00:00:00 2001 > From: Sreedhara DS > Date: Fri, 28 May 2010 13:53:38 +0530 > Subject: [PATCH] changes to find platform type during int > modified: intel_scu_ipc.c > > > Signed-off-by: Sreedhara DS Code is fine but your subject/comments don't reflect the patch. That causes problems for the upstream merge because the upstream history needs to accurately describe it. Something like Subject: intel_scu_ipc: detect CPU type automatically Intel SCU message formats depend upon the processor type. Replace the module option with automatic detection of the processor type. ---- Code looks fine and I'll add it to the Meego working tree but with the comment I quoted if that is ok Alan