Re: [PATCH]: aic94xx: fix uninitialized variable warning

[Rolf Eike Beer <eike-kernel@sf-tec.de>]

[-- Attachment #1: Type: Text/Plain, Size: 1064 bytes --]

Prarit Bhargava wrote:
> Fixes warning:
> 
> drivers/scsi/aic94xx/aic94xx_sds.c: In function
> ‘asd_process_ctrl_a_user’: drivers/scsi/aic94xx/aic94xx_sds.c:985:
> error: ‘offs’ may be used uninitialized in this function

Your mailer has messed this up as it did not declare any character set. This 
was probably UTF8 or something like that.

> diff --git a/drivers/scsi/aic94xx/aic94xx_sds.c
> b/drivers/scsi/aic94xx/aic94xx_sds.c index edb43fd..2f1751a 100644
> --- a/drivers/scsi/aic94xx/aic94xx_sds.c
> +++ b/drivers/scsi/aic94xx/aic94xx_sds.c
> @@ -982,7 +982,7 @@ static int asd_process_ctrl_a_user(struct asd_ha_struct
> *asd_ha, struct asd_flash_dir *flash_dir)
>  {
>  	int err, i;
> -	u32 offs, size;
> +	u32 uninitialized_var(offs), size;
>  	struct asd_ll_el *el;
>  	struct asd_ctrla_phy_settings *ps;
>  	struct asd_ctrla_phy_settings dflt_ps;

I would vote for putting the declarations if different lines if one of them 
gets initialized or otherwise treated specially as it is otherwise hardly 
readable.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]