All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dkirjanov@hera.kernel.org
Cc: eric.dumazet@gmail.com, shemminger@vyatta.com,
	herbert@gondor.hengli.com.au, kaber@trash.net,
	netdev@vger.kernel.org
Subject: Re: [PATCH] net: add rtnl assertion to linkwatch_run_queue
Date: Sat, 29 May 2010 00:01:19 -0700 (PDT)	[thread overview]
Message-ID: <20100529.000119.13757121.davem@davemloft.net> (raw)
In-Reply-To: <20100527055100.GA21234@hera.kernel.org>

From: Denis Kirjanov <dkirjanov@hera.kernel.org>
Date: Thu, 27 May 2010 05:51:00 +0000

> Add RTNL assertion to linkwatch_run_queue since function 
> must be called with semaphore held
> 
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>

This function is exported purely for netdev_wait_allrefs()'s sake
and for no other purpose.

In fact, I'd say this is entirely a private functional interface
specifically built for generic network interface tear-down.

If you are trying to use this function in another context, that's
something you need to discuss with us first before we start peppering
it with various assertions.

I am not applying this patch.

      reply	other threads:[~2010-05-29  7:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-27  5:51 [PATCH] net: add rtnl assertion to linkwatch_run_queue Denis Kirjanov
2010-05-29  7:01 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100529.000119.13757121.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dkirjanov@hera.kernel.org \
    --cc=eric.dumazet@gmail.com \
    --cc=herbert@gondor.hengli.com.au \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.