From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 0/8] Suspend block api (version 8) Date: Sat, 29 May 2010 00:24:22 +0200 Message-ID: <201005290024.22915.rjw@sisk.pl> References: <20100528104415.1403541a@schatten.dmk.lab> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= Cc: Peter Zijlstra , Paul@smtp1.linux-foundation.org, LKML , Florian Mickler , Linux PM , Thomas Gleixner , Linux OMAP Mailing List , felipe.balbi@nokia.com, Alan Cox List-Id: linux-omap@vger.kernel.org On Friday 28 May 2010, Arve Hj=F8nnev=E5g wrote: > On Fri, May 28, 2010 at 1:44 AM, Florian Mickler wr= ote: > > On Thu, 27 May 2010 20:05:39 +0200 (CEST) > > Thomas Gleixner wrote: ... > > To integrate this with the current way of doing things, i gathered it > > needs to be implemented as an idle-state that does the suspend()-call? > > > = > I think it is better no not confuse this with idle. Since initiating > suspend will cause the system to become not-idle, I don't think is is > beneficial to initiate suspend from idle. It is, if the following two conditions hold simultaneously: (a) Doing full system suspend is ultimately going to bring you more energy savings than the (presumably lowest) idle state you're currently in. (b) You anticipate that the system will stay idle for a considerably long t= ime such that it's worth suspending. Thanks, Rafael From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754542Ab0E1WX1 (ORCPT ); Fri, 28 May 2010 18:23:27 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:54329 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754108Ab0E1WXZ convert rfc822-to-8bit (ORCPT ); Fri, 28 May 2010 18:23:25 -0400 From: "Rafael J. Wysocki" To: Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= Subject: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 8) Date: Sat, 29 May 2010 00:24:22 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.34-rjw; KDE/4.3.5; x86_64; ; ) Cc: Florian Mickler , Thomas Gleixner , Matthew Garrett , Alan Stern , Peter Zijlstra , Paul@smtp1.linux-foundation.org, LKML , felipe.balbi@nokia.com, Linux OMAP Mailing List , Linux PM , Alan Cox References: <20100528104415.1403541a@schatten.dmk.lab> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-Id: <201005290024.22915.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 28 May 2010, Arve Hjønnevåg wrote: > On Fri, May 28, 2010 at 1:44 AM, Florian Mickler wrote: > > On Thu, 27 May 2010 20:05:39 +0200 (CEST) > > Thomas Gleixner wrote: ... > > To integrate this with the current way of doing things, i gathered it > > needs to be implemented as an idle-state that does the suspend()-call? > > > > I think it is better no not confuse this with idle. Since initiating > suspend will cause the system to become not-idle, I don't think is is > beneficial to initiate suspend from idle. It is, if the following two conditions hold simultaneously: (a) Doing full system suspend is ultimately going to bring you more energy savings than the (presumably lowest) idle state you're currently in. (b) You anticipate that the system will stay idle for a considerably long time such that it's worth suspending. Thanks, Rafael