From: tytso@mit.edu
To: "Jayson R. King" <dev@jaysonking.com>
Cc: Stable team <stable@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Dave Chinner <david@fromorbit.com>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
Kay Diederichs <Kay.Diederichs@uni-konstanz.de>
Subject: Re: [PATCH 2.6.27.y 2/3] ext4: Fix file fragmentation during large file write.
Date: Fri, 28 May 2010 21:06:57 -0400 [thread overview]
Message-ID: <20100529010657.GM26177@thunk.org> (raw)
In-Reply-To: <4C001901.1070207@jaysonking.com>
On Fri, May 28, 2010 at 02:26:57PM -0500, Jayson R. King wrote:
> From: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Date: Thu Oct 16 10:10:36 2008 -0400
> Subject: ext4: Fix file fragmentation during large file write.
>
> commit 22208dedbd7626e5fc4339c417f8d24cc21f79d7 upstream.
>
> The range_cyclic writeback mode uses the address_space writeback_index
> as the start index for writeback. With delayed allocation we were
> updating writeback_index wrongly resulting in highly fragmented file.
> This patch reduces the number of extents reduced from 4000 to 27 for a
> 3GB file.
This isn't a critical bug fix either. I don't really care a whole
lot, since I don't plan to support ext4 with all of these patches but
if you haven't been doing a full set of testing with these patches,
I'd be very concerned about whether ext4 would be stable after
applying this patch series.
What sort of testing _have_ you done?
- Ted
next prev parent reply other threads:[~2010-05-29 1:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 19:24 [PATCH 2.6.27.y 0/3] ext4 fixes Jayson R. King
2010-05-28 19:26 ` [PATCH 2.6.27.y 1/3] ext4: Use our own write_cache_pages() Jayson R. King
2010-05-29 0:49 ` tytso
2010-05-29 1:41 ` Jayson R. King
2010-05-29 2:21 ` Jayson R. King
2010-05-30 21:25 ` tytso
2010-05-31 6:35 ` Kay Diederichs
2010-05-31 6:35 ` Kay Diederichs
2010-06-01 13:54 ` Greg Freemyer
2010-06-01 13:54 ` Greg Freemyer
2010-06-01 14:49 ` Theodore Tso
2010-06-01 15:23 ` Kay Diederichs
2010-06-01 20:06 ` Jayson R. King
2010-06-01 22:12 ` tytso
2010-06-01 20:06 ` Jayson R. King
2010-06-25 23:32 ` Patch "ext4: Use our own write_cache_pages()" has been added to the 2.6.27-stable tree gregkh
2010-05-28 19:26 ` [PATCH 2.6.27.y 2/3] ext4: Fix file fragmentation during large file write Jayson R. King
2010-05-29 1:06 ` tytso [this message]
2010-05-29 2:12 ` Jayson R. King
2010-06-25 23:32 ` Patch "ext4: Fix file fragmentation during large file write." has been added to the 2.6.27-stable tree gregkh
2010-05-28 19:27 ` [PATCH 2.6.27.y 3/3] ext4: Implement range_cyclic in ext4_da_writepages instead of write_cache_pages Jayson R. King
2010-06-25 23:32 ` Patch "ext4: Implement range_cyclic in ext4_da_writepages instead of write_cache_pages" has been added to the 2.6.27-stable tree gregkh
2010-06-25 23:32 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529010657.GM26177@thunk.org \
--to=tytso@mit.edu \
--cc=Kay.Diederichs@uni-konstanz.de \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=david@fromorbit.com \
--cc=dev@jaysonking.com \
--cc=gregkh@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.