From: mark gross <640e9920@gmail.com>
To: Nigel Cunningham <ncunningham@crca.org.au>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
markgross@thegnar.org, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux-pm] [patch] complain when users abuse the pm_qos API
Date: Sun, 30 May 2010 13:07:56 -0700 [thread overview]
Message-ID: <20100530200756.GA25545@gvim.org> (raw)
In-Reply-To: <4C019D36.8070405@crca.org.au>
On Sun, May 30, 2010 at 09:03:18AM +1000, Nigel Cunningham wrote:
> Hi.
>
> On 30/05/10 06:08, Rafael J. Wysocki wrote:
> >On Saturday 29 May 2010, mark gross wrote:
> >>The following patch is to help clean up API abusers of pm_qos where
> >>they call update_request before registering a request.
> >>
> >>--mgross
> >>
> >>--Signed-off-by: markgross<markgross@thegnar.org>
> >
> >Will there be a big issue if I push this during the next merge window?
>
> What's the point to the patch? That is: why is calling
> update_request before registering a request such a big problem that
> it demands a WARN() and dump stack?
If e1000e realy needs the latency set and makes assumptions that its
done its part, I would like to let them know that they have not
registerd the request they thought they did.
--mgross
>
> Regards,
>
> Nigel
next prev parent reply other threads:[~2010-05-30 20:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 4:50 [patch] complain when users abuse the pm_qos API mark gross
2010-05-29 20:08 ` Rafael J. Wysocki
2010-05-29 20:08 ` Rafael J. Wysocki
2010-05-29 23:03 ` [linux-pm] " Nigel Cunningham
2010-05-30 19:50 ` Rafael J. Wysocki
2010-05-30 20:11 ` mark gross
2010-05-30 20:11 ` [linux-pm] " mark gross
2010-05-30 20:55 ` Rafael J. Wysocki
2010-05-30 20:55 ` [linux-pm] " Rafael J. Wysocki
2010-05-30 19:50 ` Rafael J. Wysocki
2010-05-30 20:07 ` mark gross
2010-05-30 20:07 ` mark gross [this message]
2010-05-29 23:03 ` Nigel Cunningham
2010-05-30 20:08 ` mark gross
2010-05-30 20:08 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100530200756.GA25545@gvim.org \
--to=640e9920@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=markgross@thegnar.org \
--cc=ncunningham@crca.org.au \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.