From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 5/6] introduce __block_write_begin Date: Mon, 31 May 2010 10:10:42 +0200 Message-ID: <20100531081042.GA7127@lst.de> References: <20100530204932.GA21002@lst.de> <20100530205018.GF21002@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: jack@suse.cz, linux-fsdevel@vger.kernel.org To: viro@zeniv.linux.org.uk, npiggin@suse.de Return-path: Received: from verein.lst.de ([213.95.11.210]:56354 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757Ab0EaIKq (ORCPT ); Mon, 31 May 2010 04:10:46 -0400 Content-Disposition: inline In-Reply-To: <20100530205018.GF21002@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, May 30, 2010 at 10:50:18PM +0200, Christoph Hellwig wrote: > Split up the block_write_begin implementation - __block_write_begin is a new > trivial wrapper for block_prepare_write that always takes an already > allocated page and can be either called from block_write_begin or filesystem > code that already has a page allocated. Remove the handling of already > allocated pages from block_write_begin after switching all callers that > do it to __block_write_begin. __block_write_begin is used by modules so it needs to be exported. The one liner below needs to be folded in: Index: linux-2.6/fs/buffer.c =================================================================== --- linux-2.6.orig/fs/buffer.c 2010-05-31 09:43:07.232004136 +0200 +++ linux-2.6/fs/buffer.c 2010-05-31 10:07:38.612253821 +0200 @@ -1959,6 +1959,7 @@ int __block_write_begin(struct page *pag return block_prepare_write(page, start, start + len, get_block); } +EXPORT_SYMBOL(__block_write_begin); /* * block_write_begin takes care of the basic task of block allocation and