From: Nick Piggin <npiggin@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: viro@zeniv.linux.org.uk, jack@suse.cz, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 4/4] remove inode_setattr
Date: Tue, 1 Jun 2010 00:04:12 +1000 [thread overview]
Message-ID: <20100531140412.GJ9453@laptop> (raw)
In-Reply-To: <20100531094030.GD10001@lst.de>
On Mon, May 31, 2010 at 11:40:30AM +0200, Christoph Hellwig wrote:
> Replace inode_setattr with opencoded variants of it in all callers. This
> moves the remaining call to vmtruncate into the filesystem methods where it
> can be replaced with the proper truncate sequence.
>
> In a few cases it was obvious that we would never end up calling vmtruncate
> so it was left out in the opencoded variant:
>
> spufs: explicitly checks for ATTR_SIZE earlier
> btrfs,hugetlbfs,logfs,dlmfs: explicitly clears ATTR_SIZE earlier
> ufs: contains an opencoded simple_seattr + truncate that sets the filesize just above
>
> In addition to that ncpfs called inode_setattr with handcrafted iattrs,
> which allowed to trim down the opencoded variant.
The series all looks pretty good, ends up being quite a lot cleaner
in the core code.
This last patch is a question of a bit of churn and duplicated code
with the result of cleaner core code, and more explicitly putting
vmtruncate in the hands of the fs maintainers.
I have a bunch of fs conversions (several from you) I was going to
send to maintainers, they'll clash a bit. I'll see what ends up being
merged in 2.6.35 and try to fix up what I've got.
next prev parent reply other threads:[~2010-05-31 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 9:39 [PATCH 0/4] second batch of new truncate sequence preparations Christoph Hellwig
2010-05-31 9:40 ` [PATCH 1/4] add missing setattr methods Christoph Hellwig
2010-05-31 9:40 ` [PATCH 2/4] rename generic_setattr Christoph Hellwig
2010-05-31 9:40 ` [PATCH 3/4] default to simple_setattr Christoph Hellwig
2010-05-31 9:40 ` [PATCH 4/4] remove inode_setattr Christoph Hellwig
2010-05-31 10:36 ` Boaz Harrosh
2010-05-31 14:04 ` Nick Piggin [this message]
2010-05-31 14:08 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531140412.GJ9453@laptop \
--to=npiggin@suse.de \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.