All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Valdis.Kletnieks@vt.edu
Cc: "Stephane Eranian" <eranian@google.com>,
	"Ingo Molnar" <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	"Frédéric Weisbecker" <fweisbec@gmail.com>,
	"Mike Galbraith" <efault@gmx.de>,
	"Paul Mackerras" <paulus@samba.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Tom Zanussi" <tzanussi@gmail.com>
Subject: Re: [PATCH 1/5] perf stat: add perf stat -B to pretty print large numbers
Date: Mon, 31 May 2010 20:11:45 -0300	[thread overview]
Message-ID: <20100531231145.GA4093@ghostprotocols.net> (raw)
In-Reply-To: <77282.1275338942@localhost>

Em Mon, May 31, 2010 at 04:49:02PM -0400, Valdis.Kletnieks@vt.edu escreveu:
> the same places, -B or not -B.  I was sort of expecting that the first
> example wouldn't have commas in it, or something?  Or were those two

Right, from a quick read it seems you saw a bug in the changeset and I
saw none in the patch itself.

I've read the intent, tested the patches, found it matched the intent,
happily applied the patch with a confusing/wrong comment, too bad :-\

> examples *supposed* to be identical, and there's a not-shown 3rd example
> that shows what you get if you use -B and set the LC_NUMERIC variable?

- Arnaldo

  reply	other threads:[~2010-05-31 23:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-19  2:08 [GIT PULL v2 0/5] perf tools fixes and improvements Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH 1/5] perf stat: add perf stat -B to pretty print large numbers Arnaldo Carvalho de Melo
2010-05-19  6:28   ` Ingo Molnar
2010-05-31 19:11   ` Valdis.Kletnieks
2010-05-31 19:30     ` Stephane Eranian
2010-05-31 20:49       ` Valdis.Kletnieks
2010-05-31 23:11         ` Arnaldo Carvalho de Melo [this message]
2010-05-31 23:37           ` Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH 2/5] perf tools: Remove some unused functions Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH v2 3/5] perf probe: Fix some error exit paths Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH v2 4/5] perf probe: Don't call die() Arnaldo Carvalho de Melo
2010-05-19  2:08 ` [PATCH 5/5] perf tools: remove xstrndup, xmalloc, xzalloc Arnaldo Carvalho de Melo
  -- strict thread matches above, loose matches on Subject: below --
2010-05-19  0:27 [GIT PULL 0/5] perf tools fixes and improvements Arnaldo Carvalho de Melo
2010-05-19  0:27 ` [PATCH 1/5] perf stat: add perf stat -B to pretty print large numbers Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100531231145.GA4093@ghostprotocols.net \
    --to=acme@infradead.org \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=davem@davemloft.net \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.