diff for duplicates of <20100601071404.GH5483@bicker> diff --git a/a/1.txt b/N1/1.txt index dc6d071..06ae375 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ This patch removes some unneeded code for if opt_dentry is null because that can never happen. The function dereferences "opt_dentry" earlier when it checks -"if (opt_dentry->d_parent = opt_dentry) {". That code was added in +"if (opt_dentry->d_parent == opt_dentry) {". That code was added in 2008. This function called from security_d_instantiate(). I checked all the @@ -30,13 +30,13 @@ index 0f2fc48..07abc9c 100644 /* * Get the dentry for xattr. */ -- if (opt_dentry = NULL) { +- if (opt_dentry == NULL) { - dp = d_find_alias(inode); -- if (dp = NULL) +- if (dp == NULL) - break; - } else { - dp = dget(opt_dentry); -- if (dp = NULL) +- if (dp == NULL) - break; - } - diff --git a/a/content_digest b/N1/content_digest index 484c118..4c366b8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0[patch] smack: opt_dentry is never null in in smack_d_instantiate()\0" - "Date\0Tue, 01 Jun 2010 07:14:04 +0000\0" + "Date\0Tue, 1 Jun 2010 09:14:04 +0200\0" "To\0James Morris <jmorris@namei.org>\0" "Cc\0Casey Schaufler <casey@schaufler-ca.com>" David P. Quigley <dpquigl@tycho.nsa.gov> @@ -15,7 +15,7 @@ "that can never happen.\n" "\n" "The function dereferences \"opt_dentry\" earlier when it checks \n" - "\"if (opt_dentry->d_parent = opt_dentry) {\". That code was added in\n" + "\"if (opt_dentry->d_parent == opt_dentry) {\". That code was added in\n" "2008.\n" "\n" "This function called from security_d_instantiate(). I checked all the \n" @@ -43,13 +43,13 @@ " \t\t/*\n" " \t\t * Get the dentry for xattr.\n" " \t\t */\n" - "-\t\tif (opt_dentry = NULL) {\n" + "-\t\tif (opt_dentry == NULL) {\n" "-\t\t\tdp = d_find_alias(inode);\n" - "-\t\t\tif (dp = NULL)\n" + "-\t\t\tif (dp == NULL)\n" "-\t\t\t\tbreak;\n" "-\t\t} else {\n" "-\t\t\tdp = dget(opt_dentry);\n" - "-\t\t\tif (dp = NULL)\n" + "-\t\t\tif (dp == NULL)\n" "-\t\t\t\tbreak;\n" "-\t\t}\n" "-\n" @@ -62,4 +62,4 @@ " \t\tbreak;\n" " \t}" -9ae2d1a497c43bf106695dafc1d6bb7af37e180166771532b50b69210deb1d2a +e472d05186140991f7f53f67f2bcd1b1381e2a2961ea862389d69a216f2fb7da
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.