From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Alan Cox <alan@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] Vibrator Driver for Intel MID Platforms
Date: Tue, 1 Jun 2010 14:24:10 +0100 [thread overview]
Message-ID: <20100601132410.GA7842@srcf.ucam.org> (raw)
In-Reply-To: <20100601133513.118825bb@linux.intel.com>
On Tue, Jun 01, 2010 at 01:35:13PM +0100, Alan Cox wrote:
> > > + * If the PMIC hasn't been discovered or one is not found
> > > then
> > > + * the calls will error for us.
> >
> > Can't you do this at probe time?
>
> We have to check for errors anyway. We could also check at probe time
> but that would add ordering issues or mean we needed the scu_ipc driver
> to create the platform device for the vibrator - which given it's not
> current discoverable is a bit ugly.
The ipc driver is presumably intended to probe first (and module
dependencies will ensure that in the modular case). Once that probe has
completed, isn't it expected that scu_ipc_ioread will error if there's
no device?
--
Matthew Garrett | mjg59@srcf.ucam.org
prev parent reply other threads:[~2010-06-01 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 11:56 [PATCH] Vibrator Driver for Intel MID Platforms Alan Cox
2010-06-01 13:06 ` Matthew Garrett
2010-06-01 12:35 ` Alan Cox
2010-06-01 13:24 ` Matthew Garrett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601132410.GA7842@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alan@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.