From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Jarkko Nikula <jhnikula@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"tony@atomide.com" <tony@atomide.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>,
"Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [RFC PATCH 5/5] ASoC: omap-mcbsp: Place correct constraints for streams
Date: Tue, 1 Jun 2010 13:30:10 +0300 [thread overview]
Message-ID: <201006011330.11044.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20100601122921.6d842ae8.jhnikula@gmail.com>
On Tuesday 01 June 2010 12:29:21 ext Jarkko Nikula wrote:
> On Tue, 1 Jun 2010 11:19:30 +0300
>
> Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> > If threshold is configured to 100 (99 in register), than McBSP will
> > asserts the DMA request line, when 100 locations are free. Than DMA has
> > to send 100 words per DMA request.
> >
> > So we need to limit the period size (which is used to configure the DMA's
> > elem count - number of words per DMA request) that it shall never be
> > bigger than the threshold.
>
> Now I get it with some get hands dirty testing :-)
>
> So this is a feature of SDMA that in threshold mode the transfer size
> must equal or smaller than threshold (as says the TRM).
No exactly. This is the feature of McBSP, that the SDMA must transfer exactly
the same number of words as the McBSP threshold on DMA request.
> Still don't understand why the transfer size is dependent on peripheral FIFO
> threshold size but that's the fact and we must obey it as Eduardo's
> original patch and your's are doing.
Because, if you want to transfer in one SDMA burst more than the space free in
the McBSP FIFO, than where would the rest go?
>
> > If there is interest, I might look at this.
> > I guess this could be useful on McBSP1,3,4, and 5, which has small
> > FIFO...
>
> Yes, have a packet based DMA transfer saving power and then we have
> bunch of interrupts coming :-)
I guess it could be better than having 128 word long periods on McBSP1, 3, 4,
and 5. With small period size the applications also need to be woken up, but if
we silently handling the DMA IRQs, and the application is only woken up by every
10. DMA IRQ, it might still save some power?
--
Péter
next prev parent reply other threads:[~2010-06-01 10:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 8:16 [RFC PATCH 0/5] OMAP/ASoC: McBSP: FIFO handling related fixes Peter Ujfalusi
2010-05-31 8:16 ` [RFC PATCH 1/5] OMAP: McBSP: Function to query the FIFO size Peter Ujfalusi
2010-05-31 8:16 ` [RFC PATCH 2/5] OMAP3: McBSP: Change the way how the FIFO is handled Peter Ujfalusi
2010-05-31 17:41 ` Nishanth Menon
2010-06-01 6:59 ` Peter Ujfalusi
2010-06-02 4:24 ` Nishanth Menon
2010-05-31 8:16 ` [RFC PATCH 3/5] OMAP3: McBSP: Use the port's buffer_size when calculating tx delay Peter Ujfalusi
2010-05-31 8:16 ` [RFC PATCH 4/5] ASoC: omap-mcbsp: Save, and use wlen for threshold configuration Peter Ujfalusi
2010-05-31 8:16 ` [RFC PATCH 5/5] ASoC: omap-mcbsp: Place correct constraints for streams Peter Ujfalusi
2010-05-31 8:41 ` Peter Ujfalusi
2010-05-31 10:00 ` [alsa-devel] " Liam Girdwood
2010-05-31 11:57 ` Peter Ujfalusi
2010-06-01 6:38 ` Jarkko Nikula
2010-06-01 6:47 ` Peter Ujfalusi
2010-06-01 7:38 ` Jarkko Nikula
2010-06-01 8:07 ` Peter Ujfalusi
2010-06-01 8:19 ` Peter Ujfalusi
2010-06-01 9:29 ` Jarkko Nikula
2010-06-01 10:30 ` Peter Ujfalusi [this message]
2010-06-01 11:20 ` [alsa-devel] " Jarkko Nikula
2010-06-01 11:34 ` Peter Ujfalusi
-- strict thread matches above, loose matches on Subject: below --
2010-05-31 8:03 [RFC PATCH 0/5] OMAP/ASoC: McBSP: FIFO handling related fixes Peter Ujfalusi
2010-05-31 8:03 ` [RFC PATCH 5/5] ASoC: omap-mcbsp: Place correct constraints for streams Peter Ujfalusi
2010-05-31 8:09 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006011330.11044.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=jhnikula@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.