All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: mingo@elte.hu, norsk5@yahoo.com
Cc: hpa@zytor.com, tglx@linutronix.de, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, "Petkov,
	Borislav" <Borislav.Petkov@amd.com>
Subject: [PATCH 7/8] amd64_edac: Correct scrub rate setting
Date: Tue, 1 Jun 2010 17:18:00 +0200	[thread overview]
Message-ID: <20100601151800.GA12984@aftab> (raw)
In-Reply-To: <1275398971-12439-1-git-send-email-bp@amd64.org>

Exit early when setting scrub rate on unknown/unsupported families.

Cc: stable@kernel.org
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
 drivers/edac/amd64_edac.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 6866b98..71f5ce1 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -178,7 +178,7 @@ static int amd64_set_scrub_rate(struct mem_ctl_info *mci, u32 *bandwidth)
 
 	default:
 		amd64_printk(KERN_ERR, "Unsupported family!\n");
-		break;
+		return -EINVAL;
 	}
 	return amd64_search_set_scrub_rate(pvt->misc_f3_ctl, *bandwidth,
 			min_scrubrate);
-- 
1.7.1

  parent reply	other threads:[~2010-06-01 15:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-01 13:29 [PATCH 0/6] AMD64 EDAC fixes and updates Borislav Petkov
2010-06-01 13:29 ` [PATCH 1/6] amd64_edac: Dump syndrome size in debug mode Borislav Petkov
2010-06-01 13:29 ` [PATCH 2/6] edac: Remove EDAC_DEBUG_VERBOSE Borislav Petkov
2010-06-01 13:29 ` [PATCH 3/6] amd64_edac: Remove unneeded defines Borislav Petkov
2010-06-01 13:29 ` [PATCH 4/6] x86, mce: Notify about corrected events too Borislav Petkov
2010-06-02  7:11   ` Ingo Molnar
2010-06-01 13:29 ` [PATCH 5/6] amd64_edac: Remove polling mechanism Borislav Petkov
2010-06-01 13:29 ` [PATCH 6/6] amd64_edac: Fix DCT base address selector Borislav Petkov
2010-06-01 15:18 ` Borislav Petkov [this message]
2010-06-01 15:20 ` [PATCH 8/8] edac, mc: Improve scrub rate handling Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100601151800.GA12984@aftab \
    --to=bp@amd64.org \
    --cc=Borislav.Petkov@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=norsk5@yahoo.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.