From: Rusty Russell <rusty@rustcorp.com.au>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, mst@redhat.com
Subject: Re: [PATCH] virtio-net: pass gfp to add_buf
Date: Tue, 1 Jun 2010 16:58:54 +0930 [thread overview]
Message-ID: <201006011658.55605.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20100601.002246.149820849.davem@davemloft.net>
On Tue, 1 Jun 2010 04:52:46 pm David Miller wrote:
> From: Rusty Russell <rusty@rustcorp.com.au>
> Date: Mon, 31 May 2010 20:40:01 +0930
>
> > From: "Michael S. Tsirkin" <mst@redhat.com>
> >
> > (Dave: the virtqueue_add_buf_gfp is in Linus' tree, so please queue
> > this trivial use now. Thanks!)
> >
> > virtio-net bounces buffer allocations off to
> > a thread if it can't allocate buffers from the atomic
> > pool. However, if posting buffers still requires atomic
> > buffers, this is unlikely to succeed.
> > Fix by passing in the proper gfp_t parameter.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>
> Your code sucks, and you're wrong.
>
> Please give me positive feedback and tell me how right I am to pump up
> my ego or else I will verbally destroy you and make you feel small.
>
> Applied :-)))))))))))))))
Thanks Dave, that made my day :)
Cheers,
Rusty.
prev parent reply other threads:[~2010-06-01 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 11:10 [PATCH] virtio-net: pass gfp to add_buf Rusty Russell
2010-06-01 7:22 ` David Miller
2010-06-01 7:28 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006011658.55605.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.