From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] drm/radeon/kms: add support for internal thermal sensors Date: Tue, 1 Jun 2010 21:42:31 +0100 Message-ID: <20100601204231.GB16575@srcf.ucam.org> References: <1275424301-7507-1-git-send-email-alexdeucher@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cavan.codon.org.uk (cavan.codon.org.uk [93.93.128.6]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D6F79E844 for ; Tue, 1 Jun 2010 13:42:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1275424301-7507-1-git-send-email-alexdeucher@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alex Deucher Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Jun 01, 2010 at 04:31:41PM -0400, Alex Deucher wrote: > rv6xx/rv7xx/evergreen families supported; older asics did > not have an internal thermal sensor. Exposed via sysfs > gpu_temp attribute. This really should be done via the standard hwmon naming - some of the sensor tools depend on it. If there's only one sensor per GPU "temp1_input" is correct, with a "name" attribute indicating which card provides it. Also, make sure that you're exporting in millidegrees rather than degrees. > Note also, that most laptops use an oem specific ACPI solution for > GPU thermal information rather than using the internal thermal > sensor directly. Is there any mechanism for determining which ACPI thermal zone is associated with the GPU, or is this something that's hardcoded into the drivers? > + /* where's the best place to put this? */ > + sysfs_create_group(&rdev->dev->kobj, &evergreen_hwmon_attrgroup); They should be under the hwmon device. -- Matthew Garrett | mjg59@srcf.ucam.org