From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] drm/radeon/kms: add support for internal thermal sensors Date: Tue, 1 Jun 2010 22:45:37 +0100 Message-ID: <20100601214537.GA18864@srcf.ucam.org> References: <1275424301-7507-1-git-send-email-alexdeucher@gmail.com> <20100601204231.GB16575@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from cavan.codon.org.uk (cavan.codon.org.uk [93.93.128.6]) by gabe.freedesktop.org (Postfix) with ESMTP id C7B089E779 for ; Tue, 1 Jun 2010 14:45:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alex Deucher Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Jun 01, 2010 at 05:41:34PM -0400, Alex Deucher wrote: > On Tue, Jun 1, 2010 at 4:42 PM, Matthew Garrett wro= te: > > sensor tools depend on it. If there's only one sensor per GPU > > "temp1_input" is correct, with a "name" attribute indicating which card > > provides it. Also, make sure that you're exporting in millidegrees > > rather than degrees. > = > OK. Celsius I assume? Sorry, yes. > >> + =A0 =A0 /* where's the best place to put this? */ > >> + =A0 =A0 sysfs_create_group(&rdev->dev->kobj, &evergreen_hwmon_attrgr= oup); > > > > They should be under the hwmon device. > = > Should this be a new device? I wasn't able to find a good example of > a hwmon driver that was part of another driver rather than a > standalone device. It's what you get back from hwmon_register_device. = http://lists.freedesktop.org/archives/nouveau/2009-November/004087.html = is how I did this for nouveau, although it's not merged. -- = Matthew Garrett | mjg59@srcf.ucam.org