From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/6] sort out blockdev_direct_IO variants Date: Wed, 2 Jun 2010 01:12:02 +0200 Message-ID: <20100601231202.GA32382@lst.de> References: <20100530204932.GA21002@lst.de> <20100530204942.GB21002@lst.de> <20100601230014.GC8137@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , viro@zeniv.linux.org.uk, npiggin@suse.de, linux-fsdevel@vger.kernel.org, chris.mason@oracle.com To: Jan Kara Return-path: Received: from verein.lst.de ([213.95.11.210]:59040 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755389Ab0FAXMJ (ORCPT ); Tue, 1 Jun 2010 19:12:09 -0400 Content-Disposition: inline In-Reply-To: <20100601230014.GC8137@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jun 02, 2010 at 01:00:14AM +0200, Jan Kara wrote: > On Sun 30-05-10 22:49:42, Christoph Hellwig wrote: > > Move the call to vmtruncate to get rid of accessive blocks to the callers > > in prepearation of the new truncate calling sequence. This was only done > > for DIO_LOCKING filesystems, so the __blockdev_direct_IO_newtrunc variant > > was not needed anyway. Get rid of blockdev_direct_IO_no_locking and > > it's _newtrunc variant while at it as just opencoding the two additional > > paramters is shorted than the name suffix. > Hmm, I've noticed that you didn't add truncate code to btrfs. I see that > it already does some recovery after direct IO error but I'd like to make > sure that it won't be broken by your patches... Chris? As mentioned above __blockdev_direct_IO only called vmtruncate for the DIO_LOCKING, which does not include btrfs. And yes, there's quite a bit of things that need cleanup but didn't have it before due to the way the cleanup code was hidden, but that's not something I want to do in this transformation series.