From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: "Arce, Abraham" <x0066660@ti.com>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>
Subject: Re: [RFC] [PATCH v3 2/4] OMAP4: Keyboard device registration
Date: Wed, 2 Jun 2010 15:46:03 +0200 [thread overview]
Message-ID: <20100602154603.28fe7a16@surf> (raw)
In-Reply-To: <27F9C60D11D683428E133F85D2BB4A53043E538AA1@dlee03.ent.ti.com>
On Wed, 2 Jun 2010 07:45:07 -0500
"Arce, Abraham" <x0066660@ti.com> wrote:
> I'll remove length variable and keep snprintf, below oh_name -> kbd is used again, this will keep name defined in one single place
>
> WARN(IS_ERR(od), "Could not build omap_device for %s %s\n",
> name, oh_name);
In this case, why not:
char *oh_name = "kbd";
There's really no point in using snprintf() for statically-defined
strings.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2010-06-02 13:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 21:44 [RFC] [PATCH v3 2/4] OMAP4: Keyboard device registration Arce, Abraham
2010-06-01 4:47 ` Felipe Balbi
2010-06-01 4:49 ` Felipe Balbi
2010-06-01 17:48 ` Kevin Hilman
2010-06-01 9:43 ` Tony Lindgren
2010-06-01 15:14 ` Arce, Abraham
2010-06-01 18:53 ` Felipe Balbi
2010-06-01 20:13 ` Dmitry Torokhov
2010-06-11 7:31 ` Tony Lindgren
2010-06-02 8:28 ` Thomas Petazzoni
2010-06-02 12:45 ` Arce, Abraham
2010-06-02 13:46 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602154603.28fe7a16@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=x0066660@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.