From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcin Slusarz Subject: Re: [PATCH] nv: improve KMS detection Date: Wed, 2 Jun 2010 18:20:47 +0200 Message-ID: <20100602162047.GA2973@joi.lan> References: <20100523194645.GA15846@joi.lan> <1274654223.7344.0.camel@nisroch> <20100528184517.GA12408@soprano.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20100528184517.GA12408-J3EY2hv0KmgMOYszX5p1ytBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces+gcfxn-nouveau=m.gmane.org-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Aaron Plattner Cc: "nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , Christopher James Halse Rogers List-Id: nouveau.vger.kernel.org On Fri, May 28, 2010 at 11:45:17AM -0700, Aaron Plattner wrote: > On Sun, May 23, 2010 at 03:37:03PM -0700, Ben Skeggs wrote: > > On Sun, 2010-05-23 at 21:46 +0200, Marcin Slusarz wrote: > > > 1) DRICreatePCIBusID belongs to xserver dri module, so when it's > > > unavailable we can't format string for drmCheckModesettingSupported. > > > (This situation happened to me with KMS enabled and dri module moved > > > somewhere else by Gentoo's "eselect opengl set nvidia" switcher) > > > Open code DRICreatePCIBusID to drop dri dependency. > > > 2) Once we dropped dependency on dri module (which linked to libdrm), > > > we have to link directly to libdrm. > > An alternative, which we use in Fedora for nv/vesa is to use > > pci_device_has_kernel_driver() from libpciaccess. > > That seems better than open-coding it, and avoids a dependency on libdrm > which is nice. Well, you are trading one dependency for other. It doesn't really matter... Ben, are you going to send your patch to Aaron? Marcin