From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 03 Jun 2010 09:57:55 +0000 Subject: [patch] drm/ttm: return -EFAULT on copy_to_user error Message-Id: <20100603095755.GQ5483@bicker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Airlie Cc: Thomas Hellstrom , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Jerome Glisse , Michel =?iso-8859-1?Q?D=E4nzer?= , Dave Airlie copy_to/from_user() returns the number of bytes remaining and this function normally returns negative error codes. No one uses the ttm_bo_fbdev_io() function so this change has no impact. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c index fe6cb77..fe4a25a 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c +++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c @@ -444,7 +444,7 @@ ssize_t ttm_bo_fbdev_io(struct ttm_buffer_object *bo, const char __user *wbuf, ttm_bo_unref(&bo); if (unlikely(ret != 0)) - return ret; + return -EFAULT; *f_pos += io_size; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] drm/ttm: return -EFAULT on copy_to_user error Date: Thu, 3 Jun 2010 11:57:55 +0200 Message-ID: <20100603095755.GQ5483@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f214.google.com (mail-ew0-f214.google.com [209.85.219.214]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BF8B9E830 for ; Thu, 3 Jun 2010 02:58:11 -0700 (PDT) Received: by ewy6 with SMTP id 6so1805608ewy.12 for ; Thu, 03 Jun 2010 02:58:09 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: David Airlie Cc: Thomas Hellstrom , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Jerome Glisse , Michel =?iso-8859-1?Q?D=E4nzer?= , Dave Airlie List-Id: dri-devel@lists.freedesktop.org copy_to/from_user() returns the number of bytes remaining and this function normally returns negative error codes. No one uses the ttm_bo_fbdev_io() function so this change has no impact. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c index fe6cb77..fe4a25a 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c +++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c @@ -444,7 +444,7 @@ ssize_t ttm_bo_fbdev_io(struct ttm_buffer_object *bo, const char __user *wbuf, ttm_bo_unref(&bo); if (unlikely(ret != 0)) - return ret; + return -EFAULT; *f_pos += io_size;